Reject with error when invalid fetch() body

[ekzhang]

This is a draft PR since I can't figure out how to compile bun on my computer yet! Will work that out and then run tests to make sure it actually builds and runs.

Resolves #2014

[ekzhang]

Update: Okay, just verified it compiles and the test passes!

[Jarred-Sumner]

Suggested change

	expect(exception instanceof TypeError);
	expect(exception instanceof TypeError).toBe(true);

We haven't implemented expect(exception).toBeInstanceOf(TypeError) yet

[Jarred-Sumner]

Looks good, one nitpicky comment and then I'll merge

[ekzhang]

Ah it looks like exception instanceof TypeError isn't actually true, and now the test fails.

[ekzhang]

Any idea what's happening here? I modified the code in response.zig to raise a TypeError using JSC.toTypeError, but now when I run:

fetch("https://www.google.com", { body: "hello" }).catch(err => {
  console.log(err);
  console.log(err instanceof TypeError);
});

I get this output:

$ packages/debug-bun-darwin-*/bun-debug hello.js
1 | fetch("https://www.google.com", { body: "hello" }).catch((err) => {
   ^
TypeError: fetch() request with GET/HEAD/OPTIONS method cannot have body.
 code: "ERR_INVALID_ARG_VALUE"

      at /Users/ezhang/Documents/Work/bun/hello.js:1:0

false

Even though it prints out and displays as a TypeError, the instanceof operator still returns false.

[jwhear]

Looks good to me, thank you!

[ekzhang]

Oh, just FYI the fetch test I added in this PR is still failing @jwhear — not sure if you saw the comment I made above in thread. I was asking for advice on how to resolve that failing test.

[jwhear]

Ah, the instanceof TypeError issue; I'll look into it in a bit.

[ThatOneBro]

I think the problem is that we are creating our own TypeError class somewhere which is different from the TypeError that we are using globally. I ran into this before in a different area. I'm thinking some of these TypeErrors are not like the others.