Skip to content

Conversation

@Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Feb 11, 2023

This adds the FormData API as a global.

cc @kentcdodds

@kentcdodds
Copy link

You did all this last night!?

@Jarred-Sumner
Copy link
Collaborator Author

Only thing missing is name field in Blob.

@Jarred-Sumner Jarred-Sumner marked this pull request as ready for review February 13, 2023 08:50
@Jarred-Sumner Jarred-Sumner merged commit aa0762e into main Feb 13, 2023
@Jarred-Sumner Jarred-Sumner deleted the jarred/form-data branch February 13, 2023 08:50
@jimmywarting
Copy link

Amazing, could you share some lights into how this works under the hood in layman's terms?

  • dose this use the actual formData decoder in WebKit or is it some custom implementation?
  • what happens when really large file is being sent? are blob/files backed up by the filesystem and not in held in memory?
  • i'm curios what part Bun.file() integration had a roll in this.

I'm only curious

gornostay25 added a commit to gornostay25/svelte-adapter-bun that referenced this pull request Jul 3, 2023
- Update dependencies in `index.js` and `package.json`.
- Update `@sveltejs/kit` to version `1.21.0`.
- Update `bun-types` to version `0.5.8`.
- Update `esbuild` to version `0.17.19`.
- Update `prettier` to version `2.8.8`.
- Update `rimraf` to version `4.4.1`.
- Update `totalist` to version `3.0.1`.

This change updates the project dependencies to their latest versions, ensuring compatibility and taking advantage of new features and bug fixes.

🐛 fix(packages): add missing dependencies

- Add missing dependencies `cookie`, `devalue`, and `set-cookie-parser` to the `dependencies` object in `index.js`.
- Ensure that the `cookie`, `devalue`, and `set-cookie-parser` packages are installed and available for use.

This change addresses an issue where the mentioned dependencies were missing from the project, causing potential errors or missing functionality. By adding these dependencies, the project can utilize the features provided by `cookie`, `devalue`, and `set-cookie-parser` packages.

Fix: #14
oven-sh/bun#2051
Fix: #16
Fix: #13
@tomaszzmudzinski
Copy link

Only thing missing is name field in Blob.

@Jarred-Sumner do you plan to add name field in the future?

@Jarred-Sumner
Copy link
Collaborator Author

@tomaszzmudzinski name field was added I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants