[WIP] feat(napi): add napi-fatal-exception
#2054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
needs to be referenced in this function: then, needs to be added to this list: https://github.com/oven-sh/bun/blob/jarred/new-bundler/src/symbols.txt#L140 |
| auto globalObject = toJS(env); | ||
| JSC::JSValue value = JSC::JSValue::decode(reinterpret_cast<JSC::EncodedJSValue>(err)); | ||
| JSC::JSObject* obj = value.getObject(); | ||
| if (UNLIKELY(obj == nullptr || !obj->isErrorInstance())) { |
Collaborator
There was a problem hiding this comment.
There is a subtle difference between an exception and an error and I'm not sure this satisfies that
Collaborator
There was a problem hiding this comment.
But I'm also not sure if the value passed here is expected to be a JSC::Exception
Collaborator
There was a problem hiding this comment.
I think we can merge this since its better than the present state regardless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2053 , needs to be tested first