fix string corruption in FS entry cache #2055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // } | ||
|
|
||
| pub fn addEntry(dir: *DirEntry, entry: std.fs.IterableDir.Entry, allocator: std.mem.Allocator, comptime Iterator: type, iterator: Iterator) !void { | ||
| var _kind: Entry.Kind = undefined; |
Collaborator
There was a problem hiding this comment.
you can tell this is some of the earliest code in bun because i did not know zig very well
| dir_entries_option = rfs.entries.put(&cached_dir_entry_result, .{ | ||
| .entries = Fs.FileSystem.DirEntry.init(dir_path), | ||
| .entries = Fs.FileSystem.DirEntry.init( | ||
| Fs.FileSystem.DirnameStore.instance.append(string, dir_path) catch unreachable, |
Collaborator
There was a problem hiding this comment.
I think there are few cases where we need to clone this. The caller already cloned it except for the case you're running into, which has to do with automatic package installs
Contributor
Author
There was a problem hiding this comment.
Okay let me look into that a bit more 👍
Collaborator
There was a problem hiding this comment.
We could add a debug assertion which checks:
Fs.FileSystem.DirnameStore.instance.isSliceInBuffer(dir_path) or bun.isHeapMemory(dir_path)Then we can find the callers of this function which are not cloning the dir name
Contributor
Author
Collaborator
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.