Support yarn-like "workspaces"."packages": string[]
#2086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
added
the
bun install
alexlamsl
reviewed
Feb 16, 2023
alexlamsl
approved these changes
Feb 16, 2023
Contributor
alexlamsl
left a comment
alexlamsl
left a comment
There was a problem hiding this comment.
Changes LGTM, minor comment on the added test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn does this:
{ "workspaces": { "packages": [ "my-package" ] } }npm does this:
{ "workspaces": [ "foo" ] }let's support both, so that people using yarn workspaces (which are more popular than npm workspaces, afaict) don't see an error
there are no tests for this PR