Implement machine for Linux
#2088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kapsonfire
reviewed
Feb 16, 2023
Contributor
Kapsonfire
left a comment
Kapsonfire
left a comment
There was a problem hiding this comment.
looks good, i think @Jarred-Sumner will suggest some osx code for it.. good starting point
Collaborator
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #1981
This implements
os.machinefor Linux only. It appears that OS X hasuname(see this man page), but the Zig os package doesn't implement it. High road for Mac support is probably to contribute the implementation to the Zig std lib.For unsupported platforms "unknown" is returned.