Skip to content

Conversation

@MichaReiser
Copy link
Contributor

@MichaReiser MichaReiser commented Feb 18, 2023

This is my first contribution to bun, and I don't really know what I'm doing ;)

This PR closes #2006

It's unclear to me why the particular casing was necessary. It was added in 3054222 but I wasn't able to deduce the reason from the commit message. @Jarred-Sumner do you remember why it was added?

I updated the expected output for Bun.inspect(URL) because it's documentation says that it returns the output of console.log(URL) as a string.

@Jarred-Sumner Jarred-Sumner merged commit 8aa6ee5 into oven-sh:main Feb 18, 2023
@Jarred-Sumner
Copy link
Collaborator

Thanks for this

I don't remember why I made it only print the URL as a string, but I think we should customize the output a little more later. No need to print URLSearchParams prototype and instead should print out entries like with FormData.

But this is an improvement over status quo

@vamsaya
Copy link

vamsaya commented Feb 19, 2023

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The wrong output type of the old bug: new URL

3 participants