Skip to content

Conversation

@mlafeldt
Copy link
Contributor

@mlafeldt mlafeldt commented Feb 20, 2023

Deno has removed direct access to Deno.core:

https://deno.com/blog/v1.30#removal-of-internal-denocore

❯ bun run bench:deno
$ $DENO run -A --unstable deno.js
error: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'ops')
const { op_ffi_cstr_read, op_ffi_get_buf } = (Deno as any).core.ops;
                                                                ^
    at https://deno.land/x/[email protected]/src/util.ts:19:65
error: script "bench:deno" exited with code 1 (SIGHUP)

As a result, a newer version of sqlite3 is required:

https://deno.land/x/[email protected]/src/util.ts?source#L19

❯ bun run bench:deno
$ $DENO run -A --unstable deno.js
cpu: unknown
runtime: deno 1.30.3 (aarch64-apple-darwin)

benchmark                        time (avg)             (min … max)       p75       p99      p995
------------------------------------------------------------------- -----------------------------
SELECT * FROM "Order"         27.49 ms/iter   (26.56 ms … 28.74 ms)  28.03 ms  28.74 ms  28.74 ms
SELECT * FROM "Product"       63.81 µs/iter  (57.04 µs … 346.67 µs)  66.92 µs  76.42 µs  84.54 µs
SELECT * FROM "OrderDetail"  292.21 ms/iter (263.01 ms … 326.35 ms) 305.96 ms 326.35 ms 326.35 ms

Deno has removed direct access to Deno.core:

https://deno.com/blog/v1.30#removal-of-internal-denocore

As a result, a newer version of sqlite3 is required:

https://deno.land/x/[email protected]/src/util.ts?source#L19
@mlafeldt
Copy link
Contributor Author

Removing the version constraint would also work. LMKWYT.

Copy link
Contributor

@ThatOneBro ThatOneBro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@ThatOneBro ThatOneBro merged commit 8bcf64c into oven-sh:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants