Fix :is() selector bug with compound selectors containing type selectors #21172
+48
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSS parser was incorrectly handling :is() selectors containing compound selectors with type selectors (like input:checked). The hasTypeSelector function was only checking the first component, causing compound selectors to be incorrectly optimized and losing the space between class and type selectors. This fix ensures that compound selectors containing type selectors are not unwrapped, preventing the incorrect concatenation like .foo:is(input:checked) becoming .fooinput:checked. Fixes oven-sh#21169 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #21169 where CSS
:is()selectors containing compound selectors with type selectors were incorrectly parsed, causing malformed CSS output.The Problem
.foo:is(input:checked)was incorrectly becoming.fooinput:checked(missing space).foo:is(input:hover)was incorrectly becoming.fooinput:hover(missing space)hasTypeSelectorfunction only checked the first component of a selectorThe Fix
Modified the
hasTypeSelectorfunction insrc/css/selectors/selector.zigto check all components in a selector, not just the first one. This prevents compound selectors containing type selectors from being incorrectly unwrapped.Test Plan
test/regression/issue/21169-is-selector-bug.test.ts.foo:is(.bar)can still be optimized correctly🤖 Generated with Claude Code