fix: properly quote dependencies with colon in yarn.lock #21194
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `bun install --yarn`, dependencies with special characters like `catalog:*` and `workspace:*` were not being properly quoted in the generated yarn.lock file. This could cause installation issues when using the lockfile with yarn. This fix adds `:` to the list of characters that require quoting in dependency names, ensuring proper YAML escaping. Fixes #20774 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Updated 4:39 AM PT - Jul 19th, 2025
@autofix-ci[bot], your commit 20efc37 is building: |
dylan-conway
requested changes
Jul 21, 2025
There was a problem hiding this comment.
Let's move the test out of test/regression because the issue is not a regression. We'll probably want to update this. I think it's causing claude to always create regression tests.
bun/.cursor/rules/writing-tests.mdc
Line 22 in d2a4fb8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
catalog:*andworkspace:*:to the list of characters that require quoting in dependency namesTest plan
test/regression/issue/20774.test.tsbun bd test)bun test)Fixes #20774
🤖 Generated with Claude Code