Update test runner output with colors and diffs #2122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| res->writeHeader(std::string_view("set-cookie", 10), std::string_view( | ||
| value.is8Bit() ? reinterpret_cast<const char*>(value.characters8()) : value.utf8().data(), value.length() | ||
| )); | ||
| res->writeHeader(std::string_view("set-cookie", 10), std::string_view(value.is8Bit() ? reinterpret_cast<const char*>(value.characters8()) : value.utf8().data(), value.length())); |
Collaborator
There was a problem hiding this comment.
you have clang-format right
Member
Author
There was a problem hiding this comment.
yup, these are formatting changes after merging main
|
|
||
| Vector<std::pair<String, JSValue>> ordered_properties; | ||
| for (auto property : properties) { | ||
| JSValue propertyValue = object->getDirect(vm, property); |
Collaborator
There was a problem hiding this comment.
is this correct? we don't want to call getters or prototype values? what happens if you pass it a Response subclass?
| }; | ||
|
|
||
| pub fn determineDiffMethod(this: JSValue, other: JSValue, global: *JSGlobalObject) DiffMethod { | ||
| if ((this.isString() and other.isString()) or (this.jsType() == .RegExpObject and other.jsType() == .RegExpObject) or (this.isBuffer(global) and other.isBuffer(global))) return .character; |
Collaborator
There was a problem hiding this comment.
we could still make jsType() == .RegExpObject a fn isRegExp(this: JSValue) bool
| var buf_writer = buffered_writer.writer(); | ||
| const Writer = @TypeOf(buf_writer); | ||
|
|
||
| JSC.ZigConsoleClient.format( |
Collaborator
There was a problem hiding this comment.
we probably should make the options to format a Struct because its getting a lot of fields
Collaborator
|
thank you @SuperAuguste for the diff library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added diffz for character and line diffs. The function
diffLines()is the only change to the library.Object line diff
String character diff
Output changes for other matchers follow this format.
Before:
After: