Skip to content

Conversation

@pfgithub
Copy link
Contributor

So it doesn't cache flags that are passed to the build

@robobun
Copy link
Collaborator

robobun commented Nov 19, 2025

Updated 8:14 PM PT - Nov 21st, 2025

@pfgithub, your commit ed2f4aa has 3 failures in Build #32217 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 24860

That installs a local version of the PR into your bun-24860 executable, so you can run:

bun-24860 --bun

@pfgithub pfgithub marked this pull request as ready for review December 2, 2025 06:02
@pfgithub pfgithub merged commit e9e9324 into main Dec 2, 2025
59 of 60 checks passed
@pfgithub pfgithub deleted the pfg/cmake-cache branch December 2, 2025 06:02
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Modifications to build configuration logic in both build.zig and scripts/build.mjs. The changes adjust object linking behavior based on OS and LLVM flags, and introduce a CMake cache cleanup step before configuration.

Changes

Cohort / File(s) Summary
Build Configuration Logic
build.zig
Modified obj.no_link_obj logic in configureObj to conditionally disable object linking based on both OS (non-Windows) and no_llvm flag state.
Build Script Pre-configuration
scripts/build.mjs
Added pre-configure step to attempt deletion of buildPath/CMakeCache.txt before CMake Configure, ensuring fresh configuration state.

Possibly related PRs

Suggested reviewers

  • Jarred-Sumner
  • nektro
  • taylordotfish

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9ed5328 and ed2f4aa.

📒 Files selected for processing (2)
  • build.zig (1 hunks)
  • scripts/build.mjs (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants