test: add regression tests for building docker containers #25210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
WalkthroughThe changes add Docker build tests for Alpine, Debian, Debian Slim, and Distroless base images, modify the distroless Dockerfile to expose /etc/alternatives/which via bind-mount during build, and adjust parallel test timeouts for Docker-related tests to 60,000 ms. Changes
Possibly related PRs
Suggested reviewers
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
test/js/bun/test/parallel/test-docker-build-alpine.ts (1)
1-17: Alpine docker build test mirrors Debian Slim patternLogic and harness usage are consistent with the Debian Slim docker build test and look correct. The earlier note about possibly extracting a shared helper for these docker build tests applies here as well.
test/js/bun/test/parallel/test-docker-build-distroless.ts (1)
1-17: Distroless docker build regression test is consistent and targets the updated DockerfileThis test correctly exercises
dockerhub/distrolesswith the same docker build flags and assertions as the other images. It should catch regressions in the distroless Dockerfile, including the new bind-mount behavior forwhich.test/js/bun/test/parallel/test-docker-build-debian.ts (1)
1-17: Debian docker build test completes the docker image coverageThe Debian docker build check matches the other image tests in behavior and harness usage, providing a simple exit-code regression guard for the
dockerhub/debiancontext. Same optional helper/DRY suggestion as noted in the Debian Slim test applies here if you decide to consolidate later.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (6)
dockerhub/distroless/Dockerfile(1 hunks)scripts/runner.node.mjs(1 hunks)test/js/bun/test/parallel/test-docker-build-alpine.ts(1 hunks)test/js/bun/test/parallel/test-docker-build-debian-slim.ts(1 hunks)test/js/bun/test/parallel/test-docker-build-debian.ts(1 hunks)test/js/bun/test/parallel/test-docker-build-distroless.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
test/**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (.cursor/rules/writing-tests.mdc)
test/**/*.{js,ts,jsx,tsx}: Write tests as JavaScript and TypeScript files using Jest-style APIs (test,describe,expect) and import frombun:test
Usetest.eachand data-driven tests to reduce boilerplate when testing multiple similar cases
Files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
🧠 Learnings (21)
📓 Common learnings
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: .cursor/rules/registering-bun-modules.mdc:0-0
Timestamp: 2025-11-24T18:35:39.205Z
Learning: Add tests for new Bun runtime functionality
Learnt from: theshadow27
Repo: oven-sh/bun PR: 23798
File: packages/bun-otel/context-propagation.test.ts:1-1
Timestamp: 2025-10-19T02:44:46.354Z
Learning: In the Bun repository, standalone packages under packages/ (e.g., bun-vscode, bun-inspector-protocol, bun-plugin-yaml, bun-plugin-svelte, bun-debug-adapter-protocol, bun-otel) co-locate their tests with package source code using *.test.ts files. This follows standard npm/monorepo patterns. The test/ directory hierarchy (test/js/bun/, test/cli/, test/js/node/) is reserved for testing Bun's core runtime APIs and built-in functionality, not standalone packages.
📚 Learning: 2025-11-24T18:37:30.259Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: test/CLAUDE.md:0-0
Timestamp: 2025-11-24T18:37:30.259Z
Learning: Applies to test/**/*.test.{ts,js,jsx,tsx,mjs,cjs} : When spawning Bun processes in tests, use `bunExe` and `bunEnv` from `harness` to ensure the same build of Bun is used and debug logging is silenced
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-24T18:37:30.259Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: test/CLAUDE.md:0-0
Timestamp: 2025-11-24T18:37:30.259Z
Learning: Applies to test/js/node/test/{parallel,sequential}/*.js : For test/js/node/test/{parallel,sequential}/*.js files without a .test extension, use `bun bd <file>` instead of `bun bd test <file>` since these expect exit code 0 and don't use bun's test runner
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tsscripts/runner.node.mjstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-24T18:37:30.259Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: test/CLAUDE.md:0-0
Timestamp: 2025-11-24T18:37:30.259Z
Learning: Applies to test/**/*.test.{ts,js,jsx,tsx,mjs,cjs} : Use `-e` flag for single-file tests when spawning Bun processes
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-24T18:36:33.069Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T18:36:33.069Z
Learning: Applies to test/js/bun/**/*.test.{ts,tsx} : For Bun-specific API tests, use the `test/js/bun/` directory (for http, crypto, ffi, shell, etc.)
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-24T18:37:30.259Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: test/CLAUDE.md:0-0
Timestamp: 2025-11-24T18:37:30.259Z
Learning: Applies to test/**/*.test.{ts,js,jsx,tsx,mjs,cjs} : Use `bun:test` with files that end in `*.test.{ts,js,jsx,tsx,mjs,cjs}`
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-24T18:36:59.706Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: src/bun.js/bindings/v8/CLAUDE.md:0-0
Timestamp: 2025-11-24T18:36:59.706Z
Learning: Applies to src/bun.js/bindings/v8/test/v8/v8.test.ts : Add corresponding test cases to test/v8/v8.test.ts using checkSameOutput() function to compare Node.js and Bun output
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-14T16:07:01.064Z
Learnt from: RiskyMH
Repo: oven-sh/bun PR: 24719
File: docs/bundler/executables.mdx:527-560
Timestamp: 2025-11-14T16:07:01.064Z
Learning: In the Bun repository, certain bundler features like compile with code splitting (--compile --splitting) are CLI-only and not supported in the Bun.build() JavaScript API. Tests for CLI-only features use backend: "cli" flag (e.g., test/bundler/bundler_compile_splitting.test.ts). The CompileBuildConfig interface correctly restricts these with splitting?: never;. When documenting CLI-only bundler features, add a note clarifying they're not available via the programmatic API.
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.ts
📚 Learning: 2025-11-24T18:35:08.612Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: .cursor/rules/dev-server-tests.mdc:0-0
Timestamp: 2025-11-24T18:35:08.612Z
Learning: Applies to test/bake/dev/bundle.test.ts : Organize bundle tests in bundle.test.ts for tests concerning bundling bugs that only occur in DevServer
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-debian.ts
📚 Learning: 2025-11-24T18:35:50.422Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: .cursor/rules/writing-tests.mdc:0-0
Timestamp: 2025-11-24T18:35:50.422Z
Learning: Applies to test/cli/**/*.{js,ts,jsx,tsx} : When testing Bun as a CLI, use the `spawn` API from `bun` with the `bunExe()` and `bunEnv` from `harness` to execute Bun commands and validate exit codes, stdout, and stderr
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-10-19T02:44:46.354Z
Learnt from: theshadow27
Repo: oven-sh/bun PR: 23798
File: packages/bun-otel/context-propagation.test.ts:1-1
Timestamp: 2025-10-19T02:44:46.354Z
Learning: In the Bun repository, standalone packages under packages/ (e.g., bun-vscode, bun-inspector-protocol, bun-plugin-yaml, bun-plugin-svelte, bun-debug-adapter-protocol, bun-otel) co-locate their tests with package source code using *.test.ts files. This follows standard npm/monorepo patterns. The test/ directory hierarchy (test/js/bun/, test/cli/, test/js/node/) is reserved for testing Bun's core runtime APIs and built-in functionality, not standalone packages.
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-24T18:36:33.069Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T18:36:33.069Z
Learning: Applies to **/*.test.{ts,tsx} : Verify your test fails with `USE_SYSTEM_BUN=1 bun test <file>` and passes with `bun bd test <file>` - your test is NOT VALID if it passes with `USE_SYSTEM_BUN=1`
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-08T04:06:33.198Z
Learnt from: Jarred-Sumner
Repo: oven-sh/bun PR: 24491
File: test/js/bun/transpiler/declare-global.test.ts:17-17
Timestamp: 2025-11-08T04:06:33.198Z
Learning: In Bun test files, `await using` with Bun.spawn() is the preferred pattern for spawned processes regardless of whether they are short-lived or long-running. Do not suggest replacing `await using proc = Bun.spawn(...)` with `const proc = Bun.spawn(...); await proc.exited;`.
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-24T18:36:33.069Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T18:36:33.069Z
Learning: Applies to **/*.test.{ts,tsx} : For multi-file tests, prefer using `tempDir` from `harness` and `Bun.spawn` over other temporary directory creation methods
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-10-26T01:32:04.844Z
Learnt from: Jarred-Sumner
Repo: oven-sh/bun PR: 24082
File: test/cli/test/coverage.test.ts:60-112
Timestamp: 2025-10-26T01:32:04.844Z
Learning: In the Bun repository test files (test/cli/test/*.test.ts), when spawning Bun CLI commands with Bun.spawnSync for testing, prefer using stdio: ["inherit", "inherit", "inherit"] to inherit stdio streams rather than piping them.
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-06T00:58:23.965Z
Learnt from: markovejnovic
Repo: oven-sh/bun PR: 24417
File: test/js/bun/spawn/spawn.test.ts:903-918
Timestamp: 2025-11-06T00:58:23.965Z
Learning: In Bun test files, `await using` with spawn() is appropriate for long-running processes that need guaranteed cleanup on scope exit or when explicitly testing disposal behavior. For short-lived processes that exit naturally (e.g., console.log scripts), the pattern `const proc = spawn(...); await proc.exited;` is standard and more common, as evidenced by 24 instances vs 4 `await using` instances in test/js/bun/spawn/spawn.test.ts.
Applied to files:
test/js/bun/test/parallel/test-docker-build-distroless.tstest/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-24T18:35:50.422Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: .cursor/rules/writing-tests.mdc:0-0
Timestamp: 2025-11-24T18:35:50.422Z
Learning: Applies to test/**/*.{js,ts,jsx,tsx} : Write tests as JavaScript and TypeScript files using Jest-style APIs (`test`, `describe`, `expect`) and import from `bun:test`
Applied to files:
test/js/bun/test/parallel/test-docker-build-alpine.tstest/js/bun/test/parallel/test-docker-build-debian.tstest/js/bun/test/parallel/test-docker-build-debian-slim.ts
📚 Learning: 2025-11-24T18:37:30.259Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: test/CLAUDE.md:0-0
Timestamp: 2025-11-24T18:37:30.259Z
Learning: Applies to test/**/*.test.{ts,js,jsx,tsx,mjs,cjs} : Do not set a timeout on tests. Bun already has timeouts
Applied to files:
scripts/runner.node.mjs
📚 Learning: 2025-11-24T18:37:30.259Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: test/CLAUDE.md:0-0
Timestamp: 2025-11-24T18:37:30.259Z
Learning: Applies to test/**/*.test.{ts,js,jsx,tsx,mjs,cjs} : Do not write flaky tests. Never wait for time to pass in tests; always wait for the condition to be met instead of using an arbitrary amount of time
Applied to files:
scripts/runner.node.mjs
📚 Learning: 2025-11-24T18:36:33.069Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-24T18:36:33.069Z
Learning: Applies to **/*.test.{ts,tsx} : Do not write flaky tests - do not use `setTimeout` in tests, instead `await` the condition to be met as you are testing the CONDITION not the TIME PASSING
Applied to files:
scripts/runner.node.mjs
📚 Learning: 2025-11-24T18:37:30.259Z
Learnt from: CR
Repo: oven-sh/bun PR: 0
File: test/CLAUDE.md:0-0
Timestamp: 2025-11-24T18:37:30.259Z
Learning: Applies to test/**/*.test.{ts,js,jsx,tsx,mjs,cjs} : Prefer concurrent tests over sequential tests using `test.concurrent` or `describe.concurrent` when multiple tests spawn processes or write files, unless it's very difficult to make them concurrent
Applied to files:
scripts/runner.node.mjs
🧬 Code graph analysis (4)
test/js/bun/test/parallel/test-docker-build-distroless.ts (1)
test/harness.ts (2)
isDockerEnabled(865-888)dockerExe(861-863)
test/js/bun/test/parallel/test-docker-build-alpine.ts (1)
test/harness.ts (2)
isDockerEnabled(865-888)dockerExe(861-863)
test/js/bun/test/parallel/test-docker-build-debian.ts (1)
test/harness.ts (2)
isDockerEnabled(865-888)dockerExe(861-863)
test/js/bun/test/parallel/test-docker-build-debian-slim.ts (1)
test/harness.ts (2)
isDockerEnabled(865-888)dockerExe(861-863)
🔇 Additional comments (2)
dockerhub/distroless/Dockerfile (1)
73-77: Bind-mounting/etc/alternatives/whichis a correct, minimal fixExtending the BuildKit RUN mounts to include
/etc/alternatives/whichmatches Debian’swhichsymlink layout and fixes the transientwhichinvocation without impacting the final distroless image.scripts/runner.node.mjs (1)
79-85: Timeout adjustments align with new docker build testsUsing a 60s timeout for both
test-dnsand*-docker-*node tests is consistent with their heavier I/O/network profile, while keeping the default at 20s for normal CI runs. The ordering and conditions look correct.
RiskyMH
approved these changes
Nov 29, 2025
Contributor
RiskyMH
left a comment
RiskyMH
left a comment
There was a problem hiding this comment.
looks legit, but it seems sus to use bun:test without a .test.ts and test() name callback lol (esp because it's in a way hard to actually know it was gonna run - the docker enabled check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.