-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(v8): add competitive node:v8 getHeapSpaceStatistics #25446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dajneem23
wants to merge
8
commits into
oven-sh:main
Choose a base branch
from
dajneem23:feature/v8-getHeapSpaceStatistics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+126
−2
Open
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e395e0f
feat: #7684 add competiable node:v8 getHeapSpaceStatistics
dajneem23 a2a4622
fix: PR review
dajneem23 bb125c0
fix: update constructEmptyObject to use objectPrototype for heap spac…
dajneem23 7b89c30
fix: review reuse v8SpaceNames size
dajneem23 abdfbeb
Merge branch 'main' into feature/v8-getHeapSpaceStatistics
dajneem23 985920f
Merge branch 'main' into feature/v8-getHeapSpaceStatistics
dajneem23 45fda06
Merge branch 'main' into feature/v8-getHeapSpaceStatistics
dajneem23 af24cc4
Merge branch 'main' into feature/v8-getHeapSpaceStatistics
dajneem23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import { test, expect } from "bun:test"; | ||
| import v8 from "node:v8"; | ||
|
|
||
| test("getHeapSpaceStatistics returns an array", () => { | ||
| const stats = v8.getHeapSpaceStatistics(); | ||
| expect(Array.isArray(stats)).toBe(true); | ||
| expect(stats.length).toBeGreaterThan(0); | ||
| }); | ||
|
|
||
| test("getHeapSpaceStatistics has expected properties", () => { | ||
| const stats = v8.getHeapSpaceStatistics(); | ||
|
|
||
| for (const space of stats) { | ||
| expect(typeof space.space_name).toBe("string"); | ||
| expect(typeof space.space_size).toBe("number"); | ||
| expect(typeof space.space_used_size).toBe("number"); | ||
| expect(typeof space.space_available_size).toBe("number"); | ||
| expect(typeof space.physical_space_size).toBe("number"); | ||
|
|
||
| // All numeric values should be non-negative | ||
| expect(space.space_size).toBeGreaterThanOrEqual(0); | ||
| expect(space.space_used_size).toBeGreaterThanOrEqual(0); | ||
| expect(space.space_available_size).toBeGreaterThanOrEqual(0); | ||
| expect(space.physical_space_size).toBeGreaterThanOrEqual(0); | ||
| } | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.