Repository navigation
Conversation
Bumps vendor/WebKit to upstream WebKit/WebKit@01aaa3e0be0c via oven-sh/WebKit#352. Bun-side adaptations: - JSModuleRecord no longer stores VariableEnvironments (bug 320151): drop the declared/lexical-env plumbing from the fast-path JSModuleRecord construction and from the node:vm ModuleAnalyzer call. - JSAsyncFromSyncIterator::create takes IterationMode (bug 319435): pass Generic from ReadableStream.from's sync-iterable path. - VM::performOpportunisticallyScheduledTasks takes ApproximateTime (bug 319662).
WalkthroughChangesThe PR updates the WebKit preview version, removes module variable-environment plumbing across Rust and C++ bindings, adjusts JavaScriptCore iterator and scheduling calls, and adds regression tests for async iteration, streams, and module linking. WebKit upgrade compatibility
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
|
Updated 10:39 PM PT - Jul 26th, 2026
✅ @robobun, your commit 5e818852a7d279d6d3032cf924a6ea4f007e8055 passed in 🧪 To try this PR locally: bunx bun-pr 35910That installs a local version of the PR into your bun-35910 --bun |
The first pass over record_kinds is now purely structural validation (kind is known + buffer bounds) since JSModuleRecord no longer takes VariableEnvironments at construction. Fold the no-op arms together.
|
Found 3 issues this PR may fix:
🤖 Generated with Claude Code |
Bun already pins useExplicitResourceManagement=true in ZigGlobalObject.cpp, so the 'using enabled by default' test passed on the pre-upgrade release too and proved nothing about this sync. The remaining three cases each spawn an independent bun -e subprocess; run them concurrently.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/jsc/bindings/NodeVMSourceTextModule.cpp`:
- Line 186: Update the ModuleAnalyzer construction in NodeVMSourceTextModule to
pass the parsed feature mask from node->features() instead of AllFeatures,
matching the fallback path and preserving accurate import.meta and
top-level-await detection.
In `@test/js/bun/jsc/webkit-upgrade-01aaa3e0.test.ts`:
- Around line 4-5: Remove the suite-level regression narration in
test/js/bun/jsc/webkit-upgrade-01aaa3e0.test.ts at lines 4-5. At lines 9-11,
38-39, and 68-71, replace each explanatory regression comment with only its
relevant issue URL, or remove it when no URL applies; each retained comment must
contain exactly the issue URL.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: a4c10704-43a7-4b20-a7d9-40732ef26c4d
📒 Files selected for processing (7)
scripts/build/deps/webkit.tssrc/bundler_jsc/analyze_jsc.rssrc/jsc/bindings/BunAnalyzeTranspiledModule.cppsrc/jsc/bindings/NodeVMSourceTextModule.cppsrc/jsc/bindings/bindings.cppsrc/jsc/bindings/webcore/streams/ReadableStreamOperations.cpptest/js/bun/jsc/webkit-upgrade-01aaa3e0.test.ts
There was a problem hiding this comment.
The Bun-side adaptations look correct and the earlier review nits are addressed, but a WebKit/JSC engine bump of this size should get a human sign-off — and WEBKIT_VERSION still points at the preview tag that the description says must be replaced before merge.
What was reviewed:
JSModuleRecord::create/ModuleAnalyzersignature updates and the matching Rust FFI removals — no orphanedVariableEnvironmentreferences remain.asObject(syncRecord.iterator)inReadableStreamOperations.cppis guarded by theisObject()check a few lines earlier.ApproximateTime::now() + Seconds(until)—ApproximateTimesupports+ SecondslikeMonotonicTimedid.- Test file: prior nits applied (vacuous ERM case dropped,
describe.concurrent).
Extended reasoning...
Overview
This PR bumps the vendored WebKit/JavaScriptCore to 01aaa3e0be0c (538 upstream commits, 117 touching JSC/WTF/bmalloc) and applies the mechanical Bun-side adaptations required by three upstream API changes: JSModuleRecord/ModuleAnalyzer dropping their VariableEnvironment parameters (bug 320151), JSAsyncFromSyncIterator::create gaining an IterationMode parameter (bug 319435), and VM::performOpportunisticallyScheduledTasks switching to ApproximateTime (bug 319662). Files touched: scripts/build/deps/webkit.ts (version pin), src/bundler_jsc/analyze_jsc.rs + src/jsc/bindings/BunAnalyzeTranspiledModule.cpp (drop VariableEnvironment plumbing and dead FFI shims), src/jsc/bindings/NodeVMSourceTextModule.cpp (4-arg ModuleAnalyzer), src/jsc/bindings/bindings.cpp (ApproximateTime), src/jsc/bindings/webcore/streams/ReadableStreamOperations.cpp (IterationMode::Generic + asObject cast), plus a new 3-case regression test file.
Security risks
The Bun-side diff itself is signature plumbing with no new parsing of untrusted input, no new allocations, and no new user-reachable code paths. The one new unchecked cast, asObject(syncRecord.iterator), is safe: syncIterator is checked with isObject() before iteratorDirect builds syncRecord. The real security surface is the 538 upstream commits — the changelog lists JIT correctness and OOB fixes (bugs 318139, 318144, 319161) plus new-by-default features (Wasm multi-memory, relaxed SIMD, Iterator.zip). That surface is not reviewable from this diff and is exactly why an engine bump needs a maintainer's judgement and a green CI across all lanes.
Level of scrutiny
High. This is a JS engine upgrade — the most production-critical dependency in the repo — and WEBKIT_VERSION currently points at autobuild-preview-pr-352-39744305, which the PR description itself flags as needing to be replaced with the post-merge autobuild-<sha> before this lands. The Bun-side adaptations are individually simple and I found no issues with them, but the aggregate change (fork-side merge in oven-sh/WebKit#352 plus behavioural shifts like cooperative TLA driving, async-iterator bytecode changes, and Explicit Resource Management defaulting on) is well outside auto-approve territory.
Other factors
The three review threads from the previous run are all resolved: the vacuous ERM test case was dropped and the PR description's "User-visible" claim replaced with a "Notes" section acknowledging Bun already pinned the option; describe.concurrent was applied; and the comment-cop-flagged justification comment in analyze_jsc.rs was removed by collapsing the record-kind validation pass. No new bugs were surfaced by the bug-hunting system this run. The remaining gate is human sign-off on the engine bump and swapping the preview WebKit tag for the final one.
… tests Upstream caches Intl.DateTimeFormat instances (bug 314337) and clears the cache on VM entry when hasTimeZoneChange() trips. Bun flips the zone mid-execution via process.env.TZ / setTimeZone(), so clear vm.intlCache() alongside vm.dateCache at the three setter sites. Also bump WEBKIT_VERSION to preview-pr-352-642e4852 for the fork-side hostResolveImportedModule HostDefined probe and the Linux main-thread uid pinning opt-out, and add regression tests for the TZ cache and the HostDefined import path. [skip size check] WebKit sync adds ~600KB of upstream JSC/WTF code.
There was a problem hiding this comment.
The two issues I flagged earlier (stale Intl.DateTimeFormat cache after TZ change; HostDefined import-attribute crash on the module-loader path) both look addressed in c947998 — vm.intlCache().clearForTimeZoneChange() is now called at all three TZ-change sites, and the fork bump to 642e4852 picks up the hostResolveImportedModule probe fix. No new findings this pass, but a WebKit sync of this size (76 JSC commits, fork-side loader/main-thread changes, WEBKIT_VERSION still on a preview tag pending oven-sh/WebKit#352) needs a human sign-off and a green #82460.
What was reviewed:
intlCache().clearForTimeZoneChange()added at all three TZ setters (ZigGlobalObject, JSEnvironmentVariableMap, BunJSCModule) with a subprocess regression test.VariableEnvironmentFFI plumbing removed cleanly on both Rust and C++ sides; theRecordKind::{Declared,Lexical}Variablecases are now no-ops but still length-validated so cached buffers stay compatible.asObject(syncRecord.iterator)inReadableStreamOperations.cppis guarded by theisObject()check just above, andIterationMode::Genericmatches the spec's CreateAsyncFromSyncIterator path.
Extended reasoning...
Overview
This PR syncs Bun's WebKit fork to upstream 01aaa3e0be0c (538 commits, 76 in JSC) and adapts Bun's bindings to five upstream API changes: JSModuleRecord::create/ModuleAnalyzer dropping VariableEnvironment params, JSAsyncFromSyncIterator::create gaining IterationMode, performOpportunisticallyScheduledTasks moving to ApproximateTime, the new per-VM IntlCache, and the hostResolveImportedModule typed-probe rewrite. It touches analyze_jsc.rs, BunAnalyzeTranspiledModule.cpp, NodeVMSourceTextModule.cpp, ReadableStreamOperations.cpp, ZigGlobalObject.cpp, JSEnvironmentVariableMap.cpp, BunJSCModule.h, bindings.cpp, the WebKit version pin, and adds a five-case regression test file.
Security risks
None introduced by the Bun-side adaptations, which are mechanical signature updates plus one new cache-invalidation call. The upstream changelog itself contains three memory-safety fixes (bugs 318139, 318144, 319161) and several YARR/Wasm bounds-handling changes; those are pulled in, not authored here, and are covered by the fork-side merge review in oven-sh/WebKit#352.
Level of scrutiny
High. A WebKit upgrade replaces the JS engine under every Bun user; the Bun-side diff is small and each hunk is a targeted API adaptation, but correctness depends on the fork-side merge (two Bun-specific patches: the HostDefined probe entry and the Linux main-thread uid-1 relaxation) and on full CI across all platforms. WEBKIT_VERSION is currently pinned to a preview autobuild tag that the PR description explicitly says must be swapped for the post-merge autobuild-<sha> before this lands.
Other factors
My two earlier findings on this PR (IntlCache staleness on process.env.TZ/setTimeZone, and the type: "macro"/type: "text" link-time crash from the missing HostDefined probe entry) were both root-caused by the author and fixed in the latest push; the new test file covers both. All prior review threads are resolved. Build #82460 for c947998 was still in progress at review time. Given the coupled fork PR, the preview-tag placeholder, and the breadth of the engine change, this should be signed off by a maintainer once CI is green and the fork PR has merged.
IntlCache.h transitively includes <unicode/udat.h> which is not available to Bun's own C++ on macOS (the prebuilt WebKit tarball drops include/unicode/ there and Bun does not add system ICU to its include path). Use the new fork-side JS_EXPORT_PRIVATE VM::clearForTimeZoneChange() helper instead so the three setter sites (ZigGlobalObject, JSEnvironmentVariableMap, BunJSCModule) clear both dateCache and the new Intl.DateTimeFormat instance cache without needing IntlCache.h. Bump WEBKIT_VERSION to preview-pr-352-f8c38e23 for the helper. [skip size check] WebKit sync adds ~600KB of upstream JSC/WTF code.
There was a problem hiding this comment.
The Bun-side adaptations look correct and my earlier findings (Intl cache invalidation, HostDefined probe, vacuous ERM test, describe.concurrent) have all been addressed. Deferring to a human for the merge decision though — this is a 538-commit JSC/WTF sync with fork-side fixes in oven-sh/WebKit#352, and WEBKIT_VERSION still points at the preview build (autobuild-preview-pr-352-f8c38e23) which the description says must be bumped to the final autobuild-<sha> before merge.
What was reviewed:
VariableEnvironmentplumbing removal acrossanalyze_jsc.rs/BunAnalyzeTranspiledModule.cpp— FFI signatures match on both sides, record-kind validation still coversDeclaredVariable/LexicalVariable.- All three TZ-change sites now call
vm.clearForTimeZoneChange()(ZigGlobalObject, JSEnvironmentVariableMap, BunJSCModule) — no stragglerdateCache.clearForTimeZoneChange()remains. asObject(syncRecord.iterator)inReadableStreamOperations.cppis guarded by thesyncIterator.isObject()check just above.- New test file: five subprocess cases, concurrent, pipes drained via
Promise.all,{...bunEnv}spread for the TZ override.
Extended reasoning...
Overview
This PR bumps vendor/WebKit to upstream 01aaa3e0be0c (538 commits, 76 in JSC / 41 in WTF / 6 in bmalloc). The Bun-side diff is the set of mechanical adaptations forced by upstream API changes: JSModuleRecord::create/ModuleAnalyzer dropping VariableEnvironment params (bug 320151), JSAsyncFromSyncIterator::create gaining IterationMode (bug 319435), performOpportunisticallyScheduledTasks moving to ApproximateTime (bug 319662), and clearing the new IntlCache on runtime TZ change (bug 314337). A new test file covers each adaptation plus the fork-side HostDefined typed-probe fix.
Security risks
None specific to the Bun-side diff — no auth/crypto/permission code touched, no new user-input parsing. The upstream changelog does contain memory-safety fixes (DFG cell-type confusion, YARR OOB, instanceof IC assertion), but those are inbound fixes rather than new attack surface.
Level of scrutiny
High. A JavaScriptCore engine sync is production-critical by definition: it changes JIT tiers, YARR, module linking, Wasm defaults (multi-memory and relaxed SIMD now on), Temporal, and Intl caching underneath every Bun user. The Bun-side edits are small and look correct, but the real change is the 117 upstream JSC/WTF/bmalloc commits plus two fork-side fixes in oven-sh/WebKit#352 (the HostDefined probe and the Linux main-thread uid pin) that aren't visible in this diff. This class of PR should be signed off by a maintainer with green CI across all lanes.
Other factors
WEBKIT_VERSIONis pinned toautobuild-preview-pr-352-f8c38e23; the PR's own NOTE says to bump it to the finalautobuild-<sha>once oven-sh/WebKit#352 merges. That's an explicit pre-merge TODO.- The last robobun status shows build #83032 for HEAD
340781e0still building — CI outcome for the current head isn't confirmed in the thread. - All prior review threads (my Intl-cache and macro-crash findings, the
describe.concurrentnit, the vacuous ERM test, both CodeRabbit findings) are resolved by commitsbb72bb4d,c947998f, and340781e0. - The
asObject()cast ingetIteratorAsyncis safe:syncIterator.isObject()is checked and returns early on line 833 beforeiteratorDirectpopulatessyncRecord.iterator.
[skip size check]
There was a problem hiding this comment.
Both earlier blockers are now addressed in the current diff — the three TZ-change sites (ZigGlobalObject.cpp, JSEnvironmentVariableMap.cpp, BunJSCModule.h) route through vm.clearForTimeZoneChange() with a covering test, and the type: "macro" / HostDefined-attribute crashes are root-caused to fork-side fixes in oven-sh/WebKit#352 with a with { type: "text" } regression test here. Deferring to a human for the engine upgrade itself.
What was reviewed:
- All three TZ setters now call
vm.clearForTimeZoneChange(); no remainingdateCache.clearForTimeZoneChange()-only sites insrc/jsc. asObject(syncRecord.iterator)inReadableStreamOperations.cppis safe —syncIteratorisisObject()-checked beforeiteratorDirect.analyze_jsc.rsrecord-kind validation loop still bounds-checks and rejects unknown kinds after foldingDeclaredVariable/LexicalVariableinto the no-op arm.fallbackParseandNodeVMSourceTextModuleModuleAnalyzercalls match the new 4-arg signature;AllFeaturespreserved as pre-upgrade behaviour.
Extended reasoning...
Overview
This PR syncs Bun's WebKit fork to upstream 01aaa3e0be0c (538 commits, 76 in JSC, 41 in WTF). The Bun-side changes are adaptations to upstream API breaks: JSModuleRecord::create/ModuleAnalyzer dropped their VariableEnvironment parameters (BunAnalyzeTranspiledModule.cpp, analyze_jsc.rs, NodeVMSourceTextModule.cpp), JSAsyncFromSyncIterator::create gained an IterationMode parameter (ReadableStreamOperations.cpp), performOpportunisticallyScheduledTasks moved to ApproximateTime (bindings.cpp), and the new Intl.DateTimeFormat instance cache required TZ-change invalidation to go through a new VM::clearForTimeZoneChange() helper at all three setter sites. A five-case regression test file covers each adaptation.
Prior findings resolved
I previously flagged two 🔴 issues on the earlier revision (bb72bb4): (1) the Intl.DateTimeFormat cache was not invalidated on runtime TZ change, and (2) bun build with type: "macro" imports segfaulted across multiple CI lanes. Both are now addressed — commit 340781e routes all three TZ setters through vm.clearForTimeZoneChange() (verified by grep; no stragglers), and the macro crashes were root-caused to two fork-side issues (missing HostDefined in the hostResolveImportedModule typed probe, and the Linux main-thread uid-1 RELEASE_ASSERT from bug 319887) fixed in oven-sh/WebKit#352. The new test file adds direct coverage for both.
Security risks
None introduced by the Bun-side adaptations themselves — they are signature updates and dead-plumbing removal. The upstream changelog does include three memory-safety fixes (bugs 318139, 318144, 319161) which are net-positive.
Level of scrutiny
High, and inherently beyond bot approval. This swaps the JS engine under 538 upstream commits, with fork-side patches (the HostDefined probe, the main-thread uid assert relaxation, the AsyncContextSwapScope re-plumbing through settleDriverWithIteratorResult) that live in oven-sh/WebKit#352 and are not reviewable from this diff. The PR description also explicitly notes WEBKIT_VERSION is still on a preview tag pending the fork PR merging.
Other factors
The Bun-side changes look correct and minimal for what they are. describe.concurrent was applied per the earlier nit. CI on the latest push (#83086) was still building when the timeline was fetched, so full-suite results across all lanes should be confirmed before merge.
|
Superseded by #36267, which carries these changes forward on top of a fresh upstream sync (oven-sh/WebKit#370, |
|
Closing as superseded. oven-sh/WebKit#352 merged on 2026-07-28 ( The Bun-side adaptations are on main: the |
Bumps
vendor/WebKitto upstreamWebKit/WebKit@01aaa3e0be0c(2026-07-25). 538 upstream commits since the last sync point (2603e9eb41f0); 76 touchSource/JavaScriptCore, 41 touchSource/WTF, 6 touchSource/bmalloc(117 combined).The fork-side merge is in oven-sh/WebKit#352.
Note
WEBKIT_VERSIONcurrently points at the preview buildautobuild-preview-pr-352-f8c38e23. Once oven-sh/WebKit#352 merges tomain, bump it to the resultingautobuild-<sha>before merging this PR.Bun changes required by this upgrade
JSModuleRecordno longer storesVariableEnvironments (https://bugs.webkit.org/show_bug.cgi?id=320151)JSModuleRecord::createandModuleAnalyzerdropped their declared/lexicalVariableEnvironmentparameters; var-binding initialisation now readsUnlinkedModuleProgramCodeBlock::variableDeclarations()populated at bytecode-generation time.src/jsc/bindings/BunAnalyzeTranspiledModule.cpp,src/bundler_jsc/analyze_jsc.rs: drop theVariableEnvironmentplumbing from the fast-pathJSModuleRecordconstruction (zig__ModuleInfoDeserialized__toJSModuleRecord,JSC_JSModuleRecord__create). The serializedDeclaredVariable/LexicalVariablerecords are kept for on-disk cache format compatibility but are now skipped when reconstructing the record.dumpRecordInfono longer prints the two environments, and the unusedJSC_JSModuleRecord__declaredVariables/lexicalVariables/JSC__VariableEnvironment__addFFI shims are removed.src/jsc/bindings/NodeVMSourceTextModule.cpp:ModuleAnalyzerctor ported to the new 4-argument form.JSAsyncFromSyncIterator::createtakesIterationMode(https://bugs.webkit.org/show_bug.cgi?id=319435)src/jsc/bindings/webcore/streams/ReadableStreamOperations.cpp: passIterationMode::Genericand cast the sync iterator toJSObject*(the wrapper already fetchednext).VM::performOpportunisticallyScheduledTaskstakesApproximateTime(https://bugs.webkit.org/show_bug.cgi?id=319662)src/jsc/bindings/bindings.cpp:MonotonicTime::now()becomesApproximateTime::now().Cached
Intl.DateTimeFormatinstances (https://bugs.webkit.org/show_bug.cgi?id=314337)Upstream now caches
Intl.DateTimeFormatinstances inVM::intlCache()and clears the cache on VM entry whenhasTimeZoneChange()trips. Bun flips the zone mid-execution viaprocess.env.TZ/setTimeZone(), so the setter sites now callvm.intlCache().clearForTimeZoneChange()alongsidevm.dateCache.clearForTimeZoneChange().src/jsc/bindings/ZigGlobalObject.cpp,src/jsc/bindings/JSEnvironmentVariableMap.cpp,src/jsc/modules/BunJSCModule.hhostResolveImportedModuletyped-lookup probe (https://bugs.webkit.org/show_bug.cgi?id=320144)The removal of
AbstractModuleRecord::m_dependenciesrewrotehostResolveImportedModuleas a hardcoded loop over the four upstreamScriptFetchParameters::Typevalues. The fork adds a fifth,HostDefined, forwith { type: "text" }/"sqlite"/"toml"etc.; requests keyed with it were no longer found, so the caller dereferenced null during link and segfaulted. The probe list now includesHostDefinedunderUSE(BUN_JSC_ADDITIONS)(fork-side, in oven-sh/WebKit#352).Notes
Upstream now defaults Explicit Resource Management on (https://bugs.webkit.org/show_bug.cgi?id=248707). Bun already pinned
useExplicitResourceManagement=trueinZigGlobalObject.cpp, so this is a no-op for Bun users; the pin is kept as a defensive option alongside the other forced JSC options.Upstream changelog
Memory safety and security
Object.definePropertydescriptor cell-type confusion causing invalid cell dereference in JIT code (bug 318139)instanceofprototype-chain IC condition mismatch triggering release assertion (bug 318144)userVisibleURLwhen probing forxn--(bug 319161)Correctness
tryReadUnicodeCharreads first code unit before testing whether a second is needed (bug 320088)InputStream::reread()checks the code unit before a trail surrogate, not after (bug 319932)surrogateTagMaskto0xfc00(was0xdc00) (bug 319651).length/.namecorrectly for doubly-bound (bind().bind()) functions (bug 320017)Iterator.prototype.includesnow propagates errors thrown duringIteratorCloseon match (bug 319569)charactersToFloat()now reports failure when value fitsdoublebut overflowsfloat(bug 320069)saturatingSumvariadic overload truncating 3+ argument sums touint32_t(bug 319524)InstanceOfDFG node forObject#isPrototypeOf", which tripped a RELEASE_ASSERT (bug 320022)Language features and spec alignment
using/await using) by default (bug 248707)Iterator.zip/Iterator.zipKeyed) (bug 319921)japanesecalendar accepts ISO year/day/month/monthCode (bug 319964)UCAL_YEAR(bug 319785)PlainMonthDayreference-year drop for Chinese leap months (bug 319656)getNamedTimeZoneEpochNanoseconds(bug 319296)Performance
JSModuleRecordno longer retains the parser'sVariableEnvironments after linking (bug 320151)AbstractModuleRecord::m_dependenciesto shrink module memory (bug 320144)Heap::deleteAllUnlinkedCodeBlocks(bug 320071)tryReadUnicodeChartakes BMP fast path for any non-surrogate character (bug 319943)ArrayBuffer.isViewviaIsCellWithTypeJSType-range check (bug 319796)ArrayIndexOf/ArrayIncludesintrinsic for RegExp match arrays (bug 319351)Array#indexOf/includesskip slow path for rope elements with mismatched length (bug 319237)BigInt64Array/BigUint64Arrayallocation (bug 319872)vectorLengthHintfromArrayAllocationProfileforNewArrayWithSize(bug 317466)gcSafeMemcpyintryCreateObjectViaCloning(bug 319850)JSON.parsecreates 8-bit strings for Latin-1 values found in 16-bit input (bug 319782)Symbol.keyForreuses the symbol's cached description string (bug 319843)Intl.DateTimeFormatinstances (bug 314337)AsyncFromSyncIteratordirectly inasync_iterator_open/nextbytecodes (bug 319435)op_async_iterator_open/op_async_iterator_nextforyield*(bug 319946)selectfor more arithmetic ops (bug 319951)VectorZipX(a, all-zeros)strength reduction (bug 319991)B3LowerToAir(ARM64) (bug 271412)Math.min/Math.maxspecialized thunks intothunkGeneratorForIntrinsic(bug 319795)String.prototype.atnegative-index adjustment to branchlesscsel(bug 319789)moveConditionally32inprepareForTailCallSlow(bug 319845)emitWriteBarrierslow path inm_slowPaths(bug 319688)ApproximateTimefor deadlines in Opportunistic Task Scheduler and Incremental Sweeper (bug 319662)Wasm
ArrayBuffers now throw for all invalid resize sizes (bug 319705)releaseBBQCalleetolerate a missing BBQ callee (bug 290296)Wasm::Typeto a pointer-sized payload on 64-bit (bug 247454)WTF / bmalloc / build system
PAS_ENABLE_MTEbreaking preprocessed distributed builds (bug 319895)USE(LIBPAS)/USE(TZONE_MALLOC)when bmalloc falls back to system allocator (bug 319644)RecursiveLockAdapter::unlock()asserts against underflow / wrong-owner unlock (bug 320067)OverflowHandler.hasNODELETE(bug 318384)ParkingLot::ensureHashtable()dead check and variable shadowing (bug 320050)Vector::reverse()now usesstd::ranges::reverse()(bug 319857)deleteReleasedWeakBuckets()/isReleasedWeakBucket()fromHashTable(bug 319825)CrossThreadCopierBase<HashSet<ObjectIdentifierGeneric>>gainsIsNeededand move-copy overload (bug 319797)WeakPtr::is()/UniqueRef::is()variadic overloads toisAnyOf(bug 319815)Platform.hon Mac (bug 312033)[decide:webkit] gate passed · iteration 4 · 10 files touched
fails on main (without fix)
passes on PR (with fix)
diff hotspot
gate history · 2 passed · 1 rejected · iteration 4
evidence per changed file