Repository navigation
Conversation
objectPrototypeToString is defined ALWAYS_INLINE in ObjectPrototypeInlines.h. With only ObjectPrototype.h included, the call compiled to an extern reference that happened to resolve against an out-of-line copy JSC emitted while the fork demoted ALWAYS_INLINE to plain inline. oven-sh/WebKit#403 restores the attribute, no out-of-line copy exists, and every release link fails with an undefined symbol. Include the inlines header so this TU has the definition.
Exercises the objectPrototypeToString call sites in PartialDeepEqual (generic object tags and the ArrayBuffer branch). Verified against node v26.3.0.
Collaborator
Author
|
Closing as superseded. This was a validation run for oven-sh/WebKit#403, which merged on Aug 11, and everything it carried has since landed on main through #37352 (Bump WebKit to 3997b59485da):
Rebasing this branch would leave an empty diff, so there is nothing left to merge here. The validation results (full matrix green, musl LTO lanes clean, the binary size cost) are recorded on oven-sh/WebKit#403 for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI validation run for oven-sh/WebKit#403, which removes the December 2025 LTO de-inlining stopgap (restores
ALWAYS_INLINE/ALWAYS_INLINE_LAMBDA, moves the GC liveness checksHeap::isMarked/MarkedBlock::isMarked/MarkedBlock::Handle::isLiveback into their inline headers, and un-marksDependency::fence/loadAndFenceasNEVER_INLINE) now that the root cause is fixed (upstream 308243@main,WTF::opaque()asm missingvolatile).This pins
WEBKIT_VERSIONto the preview artifactsautobuild-preview-pr-403-a9acfec7so the full suite runs against them. The lanes that matter most are linux x64 musl release (LTO), where the original FinalizationRegistry miscompile appeared in December, plus the release lanes generally since that is where__always_inline__is active again.Findings
Build 91415 (first run): every release
build-bunlink failed withobjectPrototypeToStringis definedALWAYS_INLINEinObjectPrototypeInlines.h;NodeUtilTypesModule.cpponly includedObjectPrototype.h(the declaration) and leaned on the out-of-line copy JSC happened to emit whileALWAYS_INLINEwas demoted to plaininline. Fixed here by including the inlines header (1c25b30). That commit must ride along with whatever PR bumpsWEBKIT_VERSIONpast oven-sh/WebKit#403; it is also harmless against current WebKit.Why the include fix has no fail-before test
The defect is a build-time link error in release builds, not a behavior change, so no runtime test can fail without the fix and pass with it:
ALWAYS_INLINEdegrades to plaininline, and JSC emits weak linkonce copies of the function:nmon the preview debuglibJavaScriptCore.ashows threeW JSC::objectPrototypeToString(...)entries. A debug build therefore links and behaves identically with or without the include.build-bunlanes in build 91415 show (and what the release lanes in this PR's CI exercise with the fix applied).test/js/node/assert/deep-equal.test.tsgained behavioral coverage for thepartialDeepStrictEqualtoString-tag branches (the two call sites at NodeUtilTypesModule.cpp:712/839, verified against node v26.3.0); the release links themselves are the regression test for the include, and every release lane in this PR runs it.Results (build 91420)
194 of 196 jobs green. All build lanes link on every platform. All test lanes pass except darwin 14 x64, whose two failing files are flagged pre-existing on main by the CI tooling. The linux musl release (ThinLTO) lanes, the configuration the December stopgap was chasing, are fully green including FinalizationRegistry coverage. binary-size is red by design: +2.3 to +3.8 MB per target is the cost of restoring always_inline, a maintainer tradeoff tracked on oven-sh/WebKit#403.
Draft on purpose: if oven-sh/WebKit#403 merges, this flips to the merged sha, or gets superseded by the regular WebKit bump (which must carry the NodeUtilTypesModule include fix).