Skip to content

webkit: validate oven-sh/WebKit#403 (restore ALWAYS_INLINE) on full CI - #37306

Closed
robobun wants to merge 5 commits into
mainfrom
farm/315abf4a/webkit-preview-403
Closed

robobun wants to merge 5 commits into
mainfrom
farm/315abf4a/webkit-preview-403

Conversation

@robobun

@robobun robobun commented Aug 10, 2026 •

Copy link
Copy Markdown
Collaborator

CI validation run for oven-sh/WebKit#403, which removes the December 2025 LTO de-inlining stopgap (restores ALWAYS_INLINE / ALWAYS_INLINE_LAMBDA, moves the GC liveness checks Heap::isMarked / MarkedBlock::isMarked / MarkedBlock::Handle::isLive back into their inline headers, and un-marks Dependency::fence / loadAndFence as NEVER_INLINE) now that the root cause is fixed (upstream 308243@main, WTF::opaque() asm missing volatile).

This pins WEBKIT_VERSION to the preview artifacts autobuild-preview-pr-403-a9acfec7 so the full suite runs against them. The lanes that matter most are linux x64 musl release (LTO), where the original FinalizationRegistry miscompile appeared in December, plus the release lanes generally since that is where __always_inline__ is active again.

Findings

Build 91415 (first run): every release build-bun link failed with

undefined symbol: JSC::objectPrototypeToString(JSC::JSGlobalObject*, JSC::JSValue)
>>> referenced by NodeUtilTypesModule.cpp:712

objectPrototypeToString is defined ALWAYS_INLINE in ObjectPrototypeInlines.h; NodeUtilTypesModule.cpp only included ObjectPrototype.h (the declaration) and leaned on the out-of-line copy JSC happened to emit while ALWAYS_INLINE was demoted to plain inline. Fixed here by including the inlines header (1c25b30). That commit must ride along with whatever PR bumps WEBKIT_VERSION past oven-sh/WebKit#403; it is also harmless against current WebKit.

Why the include fix has no fail-before test

The defect is a build-time link error in release builds, not a behavior change, so no runtime test can fail without the fix and pass with it:

  • In debug builds NDEBUG is off, ALWAYS_INLINE degrades to plain inline, and JSC emits weak linkonce copies of the function: nm on the preview debug libJavaScriptCore.a shows three W JSC::objectPrototypeToString(...) entries. A debug build therefore links and behaves identically with or without the include.
  • A prebuilt release binary was already linked, so the defect cannot be observed there either; it only manifests while linking a release bun against the post-Support for completion in Bash #403 artifacts, which is exactly what the 13 failed build-bun lanes in build 91415 show (and what the release lanes in this PR's CI exercise with the fix applied).

test/js/node/assert/deep-equal.test.ts gained behavioral coverage for the partialDeepStrictEqual toString-tag branches (the two call sites at NodeUtilTypesModule.cpp:712/839, verified against node v26.3.0); the release links themselves are the regression test for the include, and every release lane in this PR runs it.

Results (build 91420)

194 of 196 jobs green. All build lanes link on every platform. All test lanes pass except darwin 14 x64, whose two failing files are flagged pre-existing on main by the CI tooling. The linux musl release (ThinLTO) lanes, the configuration the December stopgap was chasing, are fully green including FinalizationRegistry coverage. binary-size is red by design: +2.3 to +3.8 MB per target is the cost of restoring always_inline, a maintainer tradeoff tracked on oven-sh/WebKit#403.

Draft on purpose: if oven-sh/WebKit#403 merges, this flips to the merged sha, or gets superseded by the regular WebKit bump (which must carry the NodeUtilTypesModule include fix).

robobun and others added 4 commits August 10, 2026 07:45
objectPrototypeToString is defined ALWAYS_INLINE in ObjectPrototypeInlines.h.
With only ObjectPrototype.h included, the call compiled to an extern reference
that happened to resolve against an out-of-line copy JSC emitted while the
fork demoted ALWAYS_INLINE to plain inline. oven-sh/WebKit#403 restores the
attribute, no out-of-line copy exists, and every release link fails with an
undefined symbol. Include the inlines header so this TU has the definition.
Exercises the objectPrototypeToString call sites in PartialDeepEqual
(generic object tags and the ArrayBuffer branch). Verified against
node v26.3.0.
@robobun

robobun commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator Author

Closing as superseded. This was a validation run for oven-sh/WebKit#403, which merged on Aug 11, and everything it carried has since landed on main through #37352 (Bump WebKit to 3997b59485da):

  • WEBKIT_VERSION on main is now past the Support for completion in Bash #403 merge commit (currently f0f60fd2, 13 commits ahead of it).
  • The companion ObjectPrototypeInlines.h include in NodeUtilTypesModule.cpp is in main as part of that bump.

Rebasing this branch would leave an empty diff, so there is nothing left to merge here. The validation results (full matrix green, musl LTO lanes clean, the binary size cost) are recorded on oven-sh/WebKit#403 for reference.

@robobun robobun closed this Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants