Repository navigation
Conversation
|
Updated 7:05 AM PT - Aug 14th, 2026
❌ @robobun, your commit 8f5cdbd has some failures in 🧪 To try this PR locally: bunx bun-pr 38482That installs a local version of the PR into your bun-38482 --bun |
|
Warning Review limit reached
On-demand reviews are free for the next 23 days. After that, they cost $0.25 per reviewed file. Or wait 20 minutes for your next included review. View limit detailsLimit details: You’ve used all 5 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
Comment |
There was a problem hiding this comment.
LGTM — focused fix that prints integer CSS tokens from the preserved i32 instead of the 6-sig-digit f32 formatter. The one inline nit (Token::Dimension arm in TokenList::to_css) is minor and doesn't block.
Extended reasoning...
Overview
This PR fixes CSS integer-token printing so large <integer> values like z-index: 2147483647 round-trip exactly instead of being flattened to 2147480000 by the 6-significant-digit float formatter. It adds Num::exact_int() (returns int_value when it still describes value), routes write_numeric and TokenList::to_css's Token::Number arm through it via itoa, refactors write_numeric to take &Num instead of three loose args, and corrects Percentage::to_css to store the percentage integer (x as i32) rather than the unit value. Tests: 20+ new minify_test/cssTest cases in css.test.ts covering z-index/orphans/counter-set/grid-row/custom props/percentages/dimensions/pseudo-class args plus i32-boundary and non-integer fallback cases, and an updated 21907.test.ts snapshot.
Security risks
None. This is pure output formatting in the CSS printer — no untrusted-input parsing changes, no allocation sizing driven by external data, no FFI/JS interop.
Level of scrutiny
Moderate. The change touches a shared serializer helper (write_numeric) used by every raw-token printer, so regressions would be visible across the CSS test suite. I checked: the early return in the new itoa branch correctly skips the trailing-.0 logic (which only applies when int_value.is_none()); has_sign handling for +/negative values is preserved (the + is written before the branch, itoa emits - for negatives); the -0 special case is ordered before exact_int(); and the int as f32 == value guard keeps saturated/mismatched int_value producers (tokenizer at i32 bounds, serialize_dimension's reconstructed int) safe. The Percentage::to_css one-liner is a straightforward correction — the old self.v as i32 was only ever read as a boolean "is integral" flag before this PR.
Other factors
No CODEOWNERS cover src/css/. The PR description documents that the new tests fail on the released build and pass on the debug build, and that the full test/js/bun/css/ + test/bundler/css/ suites pass. The one inline finding is a [Nit] about the sibling Token::Dimension arm still passing only the f32 to serialize_dimension — real, but requires an integer > 2^24 with a non-length/angle/time/resolution unit (e.g. 16777217fr), which has no practical use, and this PR still improves that case relative to before (prints 16777216fr instead of 16777200fr). Not worth holding the merge for.
There was a problem hiding this comment.
LGTM — the follow-up commits address both prior rounds of feedback.
What was reviewed:
Token::Dimensionarm now goes throughserialize_dimension_num(&dim.num, ...), preserving the tokenizer'sint_value;16777217frtest added.exact_int()'sint as f32 == valueguard against saturated/mismatchedint_value— traced saturated i32 (3000000000), out-of-range dimensions (4294967295px), and-0throughwrite_numeric; all fall through to the existing paths.Percentage::to_cssnow storesx as i32instead of the unit fraction; verified small percentages and the huge-percentage snapshot in 21907 are unchanged.serialize_dimension_numrebuildshas_sign: value < 0.0, so+2fr/2.0frstill minify to2fr(test pins this).
Extended reasoning...
Overview
The PR fixes CSS <integer> token serialization: large values like z-index:2147483647 were being printed from the token's f32 with 6 significant digits (2147480000), collapsing distinct values. The fix adds Num::exact_int() (returns int_value when int as f32 == value) and routes write_numeric, TokenList::to_css's Token::Number/Token::Dimension arms, and serialize_dimension through it, printing via itoa when the integer still describes the float. Percentage::to_css is corrected to store the percentage integer rather than the unit fraction. write_numeric's signature changes from three loose params to &Num; all four call sites in Token::to_css/to_css_generic are updated.
Changes since my last review
My earlier inline comment flagged that the Token::Dimension arm still passed only the f32 to serialize_dimension, discarding the tokenizer's int_value. Commit 1d9bfd6 introduces serialize_dimension_num(&Num, unit, dest) and calls it from that arm; serialize_dimension(f32, ...) is now a thin wrapper for typed callers that only carry an f32. A 16777217fr test was added. The comment-cop bot's five long-comment warnings were addressed in 325ca74 and 8f5cdbd — exact_int now has a one-line doc comment and serialize_dimension_num has none. All inline threads are resolved.
Security risks
None. This is pure numeric formatting on already-parsed CSS tokens; no external input reaches new code paths, no allocation sizing changes, no unsafe blocks touched.
Level of scrutiny
Medium — numeric serialization logic across several match arms, but the change is small, the int as f32 == value guard is the single safety gate, and it's straightforward to verify. I traced the edge cases: negative zero hits the pre-existing -0 branch before exact_int(); the early return in the itoa branch skips the .0-suffix check but that check requires int_value.is_none() anyway; serialize_dimension_num rebuilds has_sign from value < 0.0 so +2fr still drops the redundant sign; saturated int_value (3000000000, 4294967295px) fails the == value check and falls through to dtoa unchanged.
Other factors
Test coverage is thorough: 25 new minify_test/cssTest cases in css.test.ts covering z-index bounds, custom properties, var() fallbacks, unknown pseudo-class arguments (verbatim path), integral percentages, fr dimensions, sign/-0 handling, and out-of-i32-range fallback — with 5 explicitly pinning unchanged behavior. The 21907 regression snapshot update is a strict improvement (2147483647px round-trips to the same f32; the old 2147480000px did not). No CODEOWNERS for src/css/. The PR description states the full test/js/bun/css/ and test/bundler/css/ suites pass on the debug build.
|
Checked this PR against #38565. Both change the CSS number printer in
Verified on current main (731aa92), with each PR's source change applied as a patch:
Both PRs stay open. |
Unparsed properties (z-index, orphans, counter-set, grid lines) and custom properties keep their <integer> values as tokens. Both token printers formatted the token's f32 with 6 significant digits, so z-index: 2147483647 and z-index: 2147483646 were both emitted as 2147480000. Print the token's int_value whenever it still describes the f32, in write_numeric and in TokenList::to_css, and make Percentage::to_css fill int_value with the percentage's integer so the same applies there.
The Token::Dimension arm of TokenList::to_css rebuilt the integer from the f32, so 16777217fr printed as 16777216fr while the Token::Number arm next to it kept the exact value. serialize_dimension_num takes the token's Num and prefers its exact integer; serialize_dimension wraps it for callers that only have an f32.
8f5cdbd to
1498bea
Compare
There was a problem hiding this comment.
LGTM — the Token::Dimension arm I flagged earlier now goes through serialize_dimension_num(&dim.num, ...), and the 16777217fr test covers it.
Checked: exact_int()'s int as f32 == value guard correctly rejects the saturated-i32 case (3000000000 still prints from the float); the early return in write_numeric's itoa branch skips the .0 suffix logic only when int_value is Some, which is when that logic would have been skipped anyway; sign handling is preserved (+ written before itoa, -0 handled first, negatives via itoa's own sign); the Percentage::to_css self.v → x fix is a real correction now that int_value is compared to the ×100 float rather than used as a bare integrality flag.
Extended reasoning...
Overview
This PR fixes lossy serialization of large CSS <integer> tokens by printing from the tokenizer's stored int_value: i32 (via bun_core::fmt::itoa) instead of the 6-significant-digit dtoa_short float path, whenever int_value as f32 == value. It touches three Rust files in src/css/ (~80 lines): adds Num::exact_int(), refactors write_numeric to take &Num, adds serialize_dimension_num and routes Token::Dimension/Percentage/Number printing plus TokenList::to_css through the Num-aware paths, and fixes Percentage::to_css to store the ×100 value in int_value rather than the 0–1 fraction. A 25-case describe("integer tokens") block is added to the existing test/js/bun/css/css.test.ts, and the issue-21907 regression snapshot is updated to expect exact i32-boundary values.
Security risks
None. This is pure serialization arithmetic on already-parsed tokens — no allocation sizing from untrusted input, no unsafe blocks, no FFI, no path/string handling. The value as i32 saturating cast was already present; the only new arithmetic is an i32 as f32 == f32 comparison, which cannot panic or overflow.
Level of scrutiny
Low-to-moderate. The change is small, mechanical, and confined to the CSS printer's numeric formatting. The tricky part — making sure the new integer path doesn't change output for cases the float path handled correctly (signs, -0, non-integers, saturated values, the .0 disambiguation suffix) — is what I traced through, and each is either handled before the new branch or excluded by exact_int() returning None. Test coverage is thorough: i32 boundaries, above-2^24, sign dropping in token lists vs. sign preservation in verbatim pseudo-class args, dimensions, percentages, and the >i32 saturation edge.
Other factors
My only prior inline finding (the Token::Dimension arm in properties/custom.rs still discarding int_value) is now addressed with a matching test. No CODEOWNERS entry covers src/css/. The github-actions inline comments on earlier line numbers appear to have been addressed by subsequent commits (the current diff is clean at those locations). Exit reason was dry_streak with no findings.
|
#46715 covers the integer rows of this PR with a different mechanism. It is meant to replace this PR, and a maintainer can pick one of the two.
The two PRs conflict in |
|
I ran the tests of this PR on a build of #46715 (ba6ce72) to compare the two PRs. Of the 25 rows that this PR adds to
This PR covers two kinds of input that #46715 does not:
#46715 covers what this PR does not: typed numbers ( The bug is still on main: canary 1.4.4-canary.20261024.1 prints |
|
Duplicate of #46715. Both PRs answer the same report: Two cases change only in this PR: a typed length from 2^24 ( |
### What does this PR do? Consolidates the open pull requests on the CSS parser (`src/css`: parsing, minifying, lowering, printing, CSS modules) into one. 179 open pull requests were in scope. Each was judged by one rule: **the output must mean to a browser what the input meant.** Every claim was run through a build of `main`, a build with the change, lightningcss 1.33 and Chromium 156 (CSSOM, computed values, painted pixels for colors and gradients), and counted against 10,116 real stylesheets: the published CSS of about 190 popular npm packages, plus stylesheets from open source repositories. 107 land here, whole or in part, most of them cut down. The source diff is net negative. Of the 10,116, 9,509 are stylesheets that someone ships. The rest are test fixtures of other tools (521), Tailwind v4 source that needs its plugin (59) and SCSS, PostCSS or template source (27). | 9,509 shipped stylesheets | `main` | this branch | |---|---|---| | fail to build | 71 | 35 | | ... of those, valid CSS that Bun rejects | | 0 | | minified output reads differently in Chromium than the input | 552 | 2 | | CSS modules with a name that is referenced but not defined, or exported but not defined | 166 | 0 | | all 10,116 | `main` | this branch | |---|---|---| | fail to build | 192 | 141 | | minified output reads differently in Chromium than the input | 593 | 15 | | build on `main`, fail here | | 0 | | right on `main`, wrong here (minified, and at the default targets) | | 0 | | size of the minified output, no targets | 162.32 MB | 162.47 MB (+0.093%) | | size of the output at the default targets | 224.1 MB | 210.2 MB (-6.2%) | A syntax error is a build error, with one exception: the IE star hack `*zoom: 1` is skipped, because tachyons and handsontable ship it. The 35 shipped stylesheets that fail are invalid CSS: 28 have a selector that Chromium drops (semantic-ui-css, swiper, @ionic/core, Adobe Spectrum, xp.css), 2 an `@import` after other rules, and one each `@supports not X and Y`, a nested `@keyframes`, a stray comma, a selector list in `::slotted()`, `@media screen\0` (govuk-frontend). The 2 that read differently fold a `color-mix()` inside a gradient (see the known gaps). The growth of the minified output is rules and declarations that `main` deleted by mistake: 87 KB of rules, 45 KB of prefixed declarations that only browser targets can rule out. #### Popular CSS that `main` breaks today - normalize.css, modern-normalize, sanitize.css: `font-family: monospace, monospace` is collapsed to `monospace`, which changes the font size from 16px to 13px (#46662). - CKEditor 5, Tabler, Carbon, VitePress, Ionic, PatternFly, Excalidraw: a rule of custom properties is deleted as a "duplicate" of a later rule with the same selector and other custom properties. 37 stylesheets lose 1,681 custom properties (#33684). - Material Components, daisyUI, DocSearch, plyr: a `var()` size loses to its own fallback (#42101). - nextra, daisyUI, CKEditor: declarations written after a nested rule are moved above it (#45462). - antd 4, purecss, govuk-frontend: browser hacks in selector lists start to apply everywhere (#42100). - foundation-sites, flatpickr, 98.css, blueprintjs, scalar, react-datepicker: the build fails on valid CSS (#46756, #38552, #38534). tachyons, handsontable: it fails on the IE star hack (#46751). - nodejs.org, Mantine: a CSS module exports classes that no rule defines, because the `@apply` or `@mixin` in them is moved out of the rule (#46759). - hint.css and 42 more: `z-index: 1000001` and `1000000` become the same number (#46715). - Adobe Spectrum: `--version: 5.0.1` prints as `5.1`. - A quarter of all stylesheets: minified output has a stray space in `align-items: center` (#41993). #### Behavior changes to look at first 1. **`light-dark()` is kept as written at the default browser targets** (#42009). The lowered form `var(--buncss-light, a) var(--buncss-dark, b)` is invalid unless a compiled `color-scheme` covers the element: 184 of the 215 real stylesheets that get it never define the variable, so every browser drops the declaration. The docs section on the polyfill is removed. 2. **`border` is not built from longhands** (#42072): `border-width:0;border-style:solid;border-color:red` stays three declarations, because `border` also resets `border-image`. 305 real stylesheets grow by 30 KB in total; `bootstrap.min.css` by 113 bytes, 5 gzipped. No real stylesheet was found where the old merge shows, so this is the one to drop if size matters more. 14 existing expectations change. 3. **A CSS module no longer exports names that only occur inside `:global(...)`** (#45487). 73 real modules lose 202 export keys, all of them names that no rule has. `import { g }` or `composes: g` of such a name becomes a build error. 4. **Container names and `@counter-style` names stay global in a CSS module** (#45247 by @mikamikasuki). `main` hashes the `@container` name but not `container-name`, so a named query never matches. postcss-modules (Vite, css-loader, Next.js) keeps them global; lightningcss and esbuild hash both. Global keeps a container that is queried from another file or from JS working. 5. **Syntax errors are build errors, also two that `main` lets through**: a media query that stops short (`@media screen and {`, `@media not {`, `@import "a.css" screen and;`) and `@media (width <) foo {`. No stylesheet of the 10,116 has either. A condition that is valid by the grammar though no browser knows it, `( ... )` or `fn( ... )`, is kept as written (#46756): `(min-width:0\0)`, `(not(hover))`. 6. **Declarations after a nested rule stay where they were written**, as a nested declarations rule (#45462). Changes the output of 199 real stylesheets; in a fuzz of 2,850 nested programs compared by computed style, `main` was wrong in 1,056 and the pull request's code, before it was trimmed here, in none. 7. **`Bun.color`**: `color()` inputs are converted instead of returned as a string (`Bun.color("color(srgb 1 0 0)", "hex")` was `"color(srgb 1 0 0)"`); `currentColor`, system colors and `light-dark()` give `null` in the converting formats instead of the keyword as a string; a relative color or `color-mix()` outside sRGB is clipped, not gamut-mapped (`hsl(from oklch(100% .399 336.3) h s l)` is `#ff5bff`, was `#fff`). 8. The `:-moz-any()` and `:-webkit-any()` copies of rules with `:is()` are gone at the default targets (#45945, #42029). The `:-webkit-any()` copy outranked the original rule: `.title{color:blue} :is(h1,h2,h3){color:red}` painted red. 5.8% of all default-target output was the `:-moz-any()` copies. 9. `Property` grows from 216 to 224 bytes: `Url` stores its text as a slice so that two `url()` values can be compared (#46895). The pull request packed a pointer and a `u32` behind `unsafe` to avoid that. #### Not in this PR, needs a decision - **Raise the default browser targets (#40369) and add a `cssTarget` option (#40368).** Today: Chrome 80, Edge 80, Firefox 78, Safari 14, Opera 67, and no public way to change them. At Vite 8's floor the output of the 9,924 stylesheets is 15.3% smaller (3.9% gzipped). About a dozen fixes here only matter at today's floor, and code for older targets is unreachable without the option. - Vendor prefixes for `user-select`, `appearance`, `hyphens` and five more (#45814): 1,116 real stylesheets lack a prefix they need at the default targets. And for `backdrop-filter` (#44648): 173. - Clip instead of gamut-map in the sRGB fallback of a plain wide-gamut color: deletes about 90 lines, changes every pinned fallback hex. If the mapping stays, #44647 by @oddharsh makes it closer to what browsers paint (colors off by 2/255 or more: 168 to 110 of 3,170 real ones). #### Changes **Rules: duplicates, merging, nesting, fallbacks** - The `:-moz-any()` copy of every rule with `:is()` or `:not(a, b)` is gone: Firefox 78 has `:is()` (#45945). 1,164 real stylesheets - Keep declarations written after a nested rule in place with a nested declarations rule (#45462). 379 real stylesheets - With nesting compiled away, an unknown at-rule inside a style rule was moved out of it: `.wrapper{@apply flex}` printed a bare `@apply flex;` and the rule was gone, so a CSS module exported a class that no rule defines. It now stays in a block under the compiled selector. 72 real modules with Tailwind's `@apply`, 25 with Mantine's `@mixin` (#46759). 316 real stylesheets - Keep !important in the rules generated for logical properties and color-scheme (#38597). 311 real stylesheets - With browser targets, remove an earlier duplicate rule only when its declaration block is equal (#46861). 171 real stylesheets - Compare custom property names in `PropertyId` equality and importance in duplicate-rule detection (#33684). 40 real stylesheets - Keep same-condition @supports rules and empty named @layer blocks (#46733). 31 real stylesheets - Keep target-added vendor prefix passes on cloned and re-minified rules, and never print a bare `:full-screen` (#43339). 12 real stylesheets - Keep the selectors on rules added for color fallbacks and logical properties (#43240). 3 real stylesheets - A later declaration of a property drops the `@supports` color copies of the earlier one, which printed after the rule and won (#45560). 2 real stylesheets - Do not merge style rules in a stylesheet that holds `revert-rule` (#46953). 1 real stylesheets - `@import ... supports(-webkit-mask: none)` kept its prefix (#38589) **Properties and shorthands** - Print align-items:center without a stray space when no safe/unsafe keyword is given (#41993). 3,317 real stylesheets - Emit the physical longhands instead of the inset shorthand for targets without it (#38583). 1,452 real stylesheets - Keep the stops of an upward gradient as written, and drop a `50%` hint only at the midpoint (#46790). 104 real stylesheets - Emit unparsed border-block-* declarations when compiling logical borders (#38582). 89 real stylesheets - Keep repeated font families and dedupe only the inserted system-ui fallbacks (#46662). 88 real stylesheets - A `width` / `height` / `min-*` / `max-*` with `var()` or `env()` was printed before the plain fallback written above it, so the fallback won (#42101). 26 real stylesheets - Keep box-orient and box-direction when flex-direction or flex-flow follows (#45672). 16 real stylesheets - Write held prefixed background declarations at every flush (#46882). 6 real stylesheets - Derive equality for Size2D and BorderRadius, and keep every prefix in the border-radius handler (#45665). 2 real stylesheets - Print `none` instead of an empty border-image, mask-border or mask-box-image value (#45143). 2 real stylesheets - Keep font/transition sub-properties on the side of the shorthand they were written on (#41990). 2 real stylesheets - CSS-wide keywords are not names: `font:12px Arial;font-family:inherit` printed `font:12px inherit`, `color-scheme:inherit` and `color-scheme:auto` printed `normal`, `transition-property:unset` was folded into `transition` (#42022). 2 real stylesheets - Only fold font longhands into `font` when the rule declared a `font` (#45459) - Keep a font family name quoted when its identifiers do not read back as the same name (#46606) - Stop rewriting valid positions into ones browsers reject (#45197) - `border` is no longer built from longhands unless the rule also sets what `border` resets (`border-image`), and an author's `border-image` reset is no longer dropped. `transition` is likewise only written where the rule wrote one, because it resets `transition-behavior` (#42072) - `border; border-image: <gradient>; border-image-slice: 1` lost the gradient in every default build (#42018) - A prefixed `linear-gradient` keeps its direction, written or generated: the prefixed syntax names the starting side and measures angles differently (#46697) **At-rules** - Print @font-face format() keywords as strings (#37979). 439 real stylesheets - Print @supports `not` conditions without a leading space (#38559). 88 real stylesheets - Reset after the number token of a unicode-range (#45835). 33 real stylesheets - Keep `<general-enclosed>` media and container conditions as written (#46756). 24 real stylesheets - A strict range such as `(width < 768px)` lowered for old targets still matched at exactly 768px. The step is now `.02px`. The `not all and` form for other units is not taken (#46806). 18 real stylesheets - Keep scanning an @supports condition after a nested block (#38552). 9 real stylesheets - Every `@counter-style name` printed as `@counter-stylename`, which browsers drop (also #46692). In a CSS module the name now stays global, like the `list-style` that refers to it (#33679). 9 real stylesheets - Keep a keyframe whose block has an invalid item (#46288). 2 real stylesheets - Read an @Property initial-value on the stylesheet's parser, keep an unmatched value as written (#45806). 2 real stylesheets - `@media {}` is `all`. A media query that stops after `and`, `or` or `not` (`@media screen and {`) is a build error; `main` printed `not all` or dropped the condition, silently. The `@layer` and type selector parts are not taken (#46869). 2 real stylesheets - Accept a name-only `@container` and a `style()` feature with no value (#46689). 1 real stylesheets - Parse `<timeline-range-name> <percentage>` keyframe selectors (#45652) - Allow `or` inside parentheses after a media type (#45088) - Print the `=` comparison in media and container queries as `=` (#45071) - Parse the @font-palette-values font-family descriptor as a list of family names (#45484) **Selectors** - Never wrap a selector list in :is() (#46787). 414 real stylesheets - Stop emitting :-webkit-any() copies of :is() that outrank the original rule (#42029). 373 real stylesheets - With browser targets, a selector list with a vendor-prefixed member was split, which revives hacks that rely on other engines dropping the whole list: `.s *::-ms-backdrop,.s{flex:auto}` applied everywhere. Rewritten; the list is printed as written (#42100). 42 real stylesheets - Print the vendor prefix on downleveled :any-link, :read-only, :read-write, :placeholder-shown and :autofill (#42131). 12 real stylesheets - Fix nesting lowering of a `&` that does not lead its selector (#43047). 8 real stylesheets - `@scope`: `&` and implicit selectors compile to `:where(:scope)`, relative selectors and bare declarations parse (#43165). 7 real stylesheets - Only reject bare :global / :local pseudo-classes in CSS modules (#38534). 5 real stylesheets - Stop truncating `@scope to (...)` and stop replacing `&` in the scope-end selector (#43146). 2 real stylesheets - `[xl|href$=".pdf"]` lost its namespace prefix (#45159). 2 real stylesheets - Match An+B keywords exactly and take only `+` as the leading sign (#42953). 1 real stylesheets - Parse ::details-content and ::picker() like ::part() (#45504). 1 real stylesheets - Parse :window-inactive as an ordinary pseudo-class, and accept it after ::selection (#45815) - Print :nth-col(1) and :nth-last-col(1) in functional form (#41575) - `li::before::marker` failed the build (#45810) - `&` inside `:nth-child(... of S)` is resolved when nesting is compiled away. The second selector serializer (326 lines) is deleted (#43024) **Colors and `Bun.color`** - Keep light-dark() as written under the default browser targets (#42009). 227 real stylesheets - Number and percentage channels parse in `lab()`, `lch()`, `oklab()`, `oklch()`, `hsl()` and `hwb()`; the hue of `lch` / `oklch` is no longer scaled by alpha (#45084). 130 real stylesheets - `Bun.color` returns `null` for `currentColor`, system colors and `light-dark()` in the converting formats, instead of the CSS keyword as a string (#33047). 130 real stylesheets - Relative colors: channel keywords are on the scale of their function (`rgb(from #369 calc(r + 10) g b)`), the origin's alpha is kept, a relative color kept as written gets no `@supports` copies, and a result outside sRGB is not folded (#45362). 31 real stylesheets - Keep rotate: 0deg out of none, and keep the origin alpha in relative colors (#38486). 13 real stylesheets - Compute the D50 reference white in f32 so greys convert to lab(l 0 0) like lightningcss (#38535). 7 real stylesheets - Return a missing hue for a grey from conversions into lch, oklch, hsl and hwb (#45201). 5 real stylesheets - Fix color(a98-rgb), srgb-linear relative colors and color-mix(in xyz-d50) (#38487). 4 real stylesheets - Match named colors without regard to ASCII case (#45092). 3 real stylesheets - Fold min(), max() and clamp() over plain numbers (#39515) - `calc(l - .08)` in a percentage channel of a relative color became NaN and printed `#000` (also #45970) (#45971) - Bun.color: convert color() inputs instead of returning them as a CSS string (#38488) - A `color-mix(in srgb, ...)` result outside sRGB prints `color(srgb ...)` instead of a gamut-mapped hex (#39269) **`calc()` and numbers** - Rounding to 6 significant digits ate into the integer part: `z-index:2147483647` became `2147480000`, `max-width:9999999px` became `10000000px`, `--x:1234567.5` became `1234570`. It now only cuts a fraction short: a value kept as tokens prints its source text, a typed value prints every integer digit and at least one digit of the fraction (#46715). 43 real stylesheets - A number without a unit is no longer repaired into `px` (`height:1.5715` is dropped by a standards-mode browser, so it prints as written), `calc(-1 * 0)` is not a length, and on a property of the range [0,∞] (sizes, border radii, padding, border and outline widths, gap, `flex-basis`, `font-size`) a `calc()` that folds below zero prints `0` instead of an invalid negative literal, and a negative literal no longer replaces the valid declaration before it (`width:10px;width:-5px` printed `width:-5px`) (#42104). 24 real stylesheets - Print numbers from the f32's shortest digits, not its f64 expansion (#38565). 17 real stylesheets - Print negative numbers below 1 with a single minus sign (#38516) - Keep math functions over two different length units as written (#38489) - Fold rem() with a truncated quotient, so it keeps the sign of the dividend (#32286) - A one-argument `min()` / `max()` around a sum printed without any function (`width:100% - 20px`) (#46145) - `round()` breaks ties upward and handles a negative step as browsers do (#45249) **CSS modules** - A CSS module exports its `@keyframes` names (`styles.spin`). Hashing is unchanged (#46720). 145 real stylesheets - A name inside `:global(...)` prints plain but was exported as `name_<hash>`, a class no rule has (also #38573) (#45487). 90 real stylesheets - Keep container names global in CSS modules (#45247). 6 real stylesheets - Tag the keyframes name when an `animation` value falls back to raw tokens (#46034). 6 real stylesheets - In a plain stylesheet `composes: a from "./b.css"` was treated as an import: the file was inlined and an absolute path printed (#45961). 4 real stylesheets - Drop a rejected composes instead of failing the file at print time (#38538). 1 real stylesheets - Keep every rule's custom properties for the composes conflict check (#38523) - Keep composes working after a nested rule in the same block (#38520) - `IdentOrRef::hash` read 2 of 16 bytes, so in release builds every class of a module hashed alike (#30784) **Tokens, `url()`, diagnostics** - The block skip stack no longer allocates on every block exit (#39533) - Report the diagnostic's line without its line breaks in position.lineText (#38342). 192 real stylesheets - Compare `url()` values by their text (#46895). 26 real stylesheets - Values kept as tokens keep the blanks they were written with instead of having them re-invented at print time: `attr(x type(<number>))` printed `type(< number> )`, which browsers drop. Minified output still drops the blanks that cannot matter (#45577). 19 real stylesheets - The IE star hack (`*zoom:1`) failed the whole build. The declaration is skipped, as every browser does. It is the one syntax error that builds: tachyons, handsontable and jasmine ship it (#46751). 8 real stylesheets - The path of a copied asset spliced into `url()` is always quoted, so a file name with a space or a parenthesis cannot end the `url()` (#41557). 7 real stylesheets - Move the skip loop of parse_until_before out of the generic body (#39520) - Remove dead code from bun_css: the unused `impl Default for Property` (#45618) - Default the at-rule and qualified-rule parser traits, drop the url_to_css shim (#31999) **Speed** Four inputs that took quadratic or exponential time, or produced output out of proportion, are now linear, with no new limit and no extra pass (#31639, #42243, #38531, #43421). **Tests only** - `css-fuzz.test.ts` never ran in CI and timed out on debug builds; it is a deterministic table now (#38500) - `nth-anplusb-ident.test.ts` counts heaps in a child process (#46331) - `color.test.ts` checks the ansi-16 sweep with one `expect()` (#42824) - Not CSS, but it failed this PR's CI and fails on `main` too: `ws-proxy.test.ts` on Windows, "a message sent during a TLS renegotiation arrives after it". The helper server now renegotiates from the callback of the frame's write (#46170) **No pull request covered these** - `--v: 5.0.1` printed as `5.1`, `--w: 1.0.0` as `10`, `--x: 1+2` as `12`, `2n+1` as `2n1`: a number token that touches another keeps its source text. - `color-scheme: auto` printed as `normal`, and `color-scheme: dark light` as `light dark`. - A bare `:global` or `:local` in a CSS module sets the scope of the names after it, up to the end of the selector, as in css-loader. It was a build error. - The scrollbar states (`a:horizontal`, `::-webkit-scrollbar{&:horizontal{}}`) are valid in a plain compound, as in WebKit and Blink. - Without browser targets, `-webkit-box-align`, `-ms-flex-align` and the like were dropped next to their standard form (flatpickr, foundation-sites, materialize-css: 28 stylesheets), and `-webkit-fill-available` before `-moz-available` (beercss). - `(-o-min-device-pixel-ratio: 2/1)` printed as `2`. - `sin()`, `cos()` and `tan()` are exact at multiples of 90deg: `calc(100px * cos(90deg))` printed `-.00000437114px`. - A `display-p3` color at targets that have P3 but not the other `color()` spaces (Safari 10.1 to 14) got itself as a fallback. - `width: rem(-18px, 5px)` folds to a negative literal once `rem()` is right; it prints `0`. - Consecutive nested declarations rules, which arise when same-query `@media` blocks in one rule merge, are folded into one and count against the existing selector expansion limit as the `&{}` rules they replace did. #### Known and not fixed here - Four longhands are still folded into a `transition` the author did not write where the targets add a prefixed copy of a property (`mask-image` at Chrome 80): only the shorthand gives the copy its own times. - A later `background`, `box-shadow` or `border-*` declaration still loses to the `@supports` copy of an earlier `var()` value of the same property with a wide-gamut color. Same on `main`; #45560 is taken for the properties of the fallback handler and for unparsed values only. - A merged rule prints the unprefixed name in the passes of the rule it absorbed: `.d::-webkit-input-placeholder{}.d::-moz-placeholder{}` prints `::placeholder` for the second (#42106, not taken: it breaks the merge of prefix-equivalent rules). - The `border`, `outline` and `font` shorthands, `line-height`, `scroll-padding`, `background-size` and a few more still print a `calc()` that folds below zero as a negative literal. No real stylesheet has one. - `all` is not a property Bun knows, so `a{margin-top:1px;all:unset}` prints `all` first. Same on `main`. - A selector kept as raw tokens loses the blank before `*` when minified: `--sel: .dark *` prints `.dark*`. Same on `main`. - `width:calc(0% + 12px)` folds to `12px`, which lays out differently in a table cell. Same on `main`. - The `:dir()` / `:lang()` rules of a lowered logical property print before the nested rules of their rule, so a logical declaration written after a nested rule of equal specificity still loses to it. Same on `main`. - A fraction is still rounded to 6 significant digits (`12345.678` prints `12345.7`, `33.3333333333%` prints `33.3333%`). Keeping every digit would add up to 282 KB over the corpus. - `@keyframes "quoted"` is hashed in a module but not exported. - In a module, a keyframes name inside a `var()` fallback is not hashed: `animation: var(--enter, fade 1s)`. Same on `main`. - A `color-mix()` or relative color folded to a hex inside a gradient changes the interpolation from Oklab to sRGB (VS Code, clawhub). Printing `color(srgb ..)` instead needs a fallback for `mask-image`, `list-style-image` and custom properties at the default targets, which have none. - A comma list in `@container` still fails the build. - After a bare `:global`, names that are hashed at print time (`::view-transition-old(foo)`) are still hashed; inside `:global(...)` they are not. #### Pull requests in scope that do not land here - Duplicates of a pull request that lands here: #36961 (of #37979), #38478 (of #46662), #38480 (of #46733), #38482 (of #46715), #38491 (of #38500), #38508 (of #45201), #38513 (of #45362), #38573 (of #45487), #38640 (of #38500), #45525 (of #45247), #45589 (of #46756), #45970 (of #45971) - Already fixed on `main`: #38674 - Right, but for input nobody writes (0 of 10,116 stylesheets, and not new syntax): #31916, #38526, #38592, #39349, #41139, #41801, #42042, #42484, #43078, #45604, #45908, #46086, #46221, #46224, #46273, #46694, #46707, #46737, #46755, #46816, #46870, #46934 - Right or harmless, but not worth their code, their bigger output or the behavior they change: #30905, #31924, #33332, #34426, #36225, #38006, #38512, #38547, #38551, #38561, #38572, #38576, #38607, #38623, #38667, #38692, #42106, #42912, #42918, #43407, #43434, #44700, #45442, #45546, #45747, #45759, #45825, #45946, #46061, #46127, #46206 - Need a decision (see above), stay open: #40368, #40369, #44647, #44648, #45814 - Stays open: #45787 Out of scope: CSS linking and chunking in the bundler, the dev server, docs-only pull requests, and repository-wide sweeps that touch `src/css` in passing. Thanks to @mikamikasuki (#45247), @alii (#39520, #31999) and @oddharsh, whose measurements on #40369 and #41990 were used. Fixes #16727. Fixes #24770. Fixes #30772. Fixes #44704. Fixes #45089. Fixes #45237. Fixes #46872. ### How did you verify your code works? - The 35 CSS test files pass on a debug build, also with `FORCE_COLOR=1`. 600+ of the tests in this branch fail on a build of `main`. An earlier head of this branch passed all 179 CI jobs that ran. - The reproduction of each issue listed above was run on `main` (wrong) and on this branch (right). - Differential run over the 10,116 stylesheets, `main` against this branch, minified without targets and through `Bun.build` at the default targets: no stylesheet that builds on `main` fails; Chromium 156 compares the output with the input rule by rule (CSSOM, then computed values on a sized element in a standards-mode document, colors as painted pixels in sRGB and P3). The comparison has 195 control pairs that must read equal or different. For stylesheets that read differently on both builds, mostly because of lowering, the sets of differences were compared; the three new ones are two minifier fixtures that are wrong on both and one comparison artifact. - CSS modules are checked for consistency instead, since hashed names defeat the comparison: every reference points at a name the output defines, every export exists. - `Bun.color`: 59 inputs in 13 formats on both builds; every changed cell was read.
Problem
bun buildrewrites large CSS<integer>values:a{z-index:2147483647} b{z-index:2147483646}comes out asz-index:2147480000for both, so two distinct stacking levels become the same one and DOM order decides which is on top. Same for--z:2147483647,orphans:16777217(printed16777200),counter-set:n 2147483647,grid-row:2147483647. Happens with and without--minify.value: f32and, for an<integer-token>, the exactint_value: i32(src/css/css_parser.rsconsume_numeric). Both printers ignoreint_valueand format the f32 with 6 significant digits:TokenList::to_css(src/css/properties/custom.rs:420) printsToken::NumberthroughCSSNumberFns::to_css(v.value). This is the path for every property bun has no typed entry for (z-index included) and for custom properties.serializer::write_numeric(src/css/css_parser.rs) prints raw tokens (percentage tokens in token lists, unknown pseudo-class arguments, and theserialize_dimensionhelper used by typed lengths) withdtoa_short(value, 6).z-indexproperty, which bun's port does not have; it has the same loss for custom properties.Fix
Num::exact_int()returnsint_valuewhenint_value as f32 == value, i.e. when the integer still describes the float.write_numericand theToken::Numberarm ofTokenList::to_cssprint that integer with itoa and fall back to the existing float path otherwise.Token::Dimensionarm ofTokenList::to_cssgoes throughserialize_dimension_num, which takes the token'sNumand prefers its exact integer (16777217frused to come back as16777216fronce the f32 had rounded it);serialize_dimensionis now a wrapper over it for the typed callers that only have an f32.int_valueat the i32 range (3000000000keeps printing from the float), andserialize_dimensionsynthesizesint_valuewith a saturating cast.Percentage::to_cssused to fillint_valuewith the unit value (0for50%) purely as an "is integral" flag; it now stores the percentage's integer so integral percentages print in full too.<number>properties (opacity,line-height, ...) and the.0/+/-0round-trip rules are untouched.test/js/bun/css/css.test.ts("integer tokens"): 20 of the 25 new cases fail on the released build (the other 5 pin behavior that must not change), all 25 pass with the fix.test/regression/issue/21907.test.ts: snapshot updated.margin:2147483647px/padding:-2147483648pxnow print exactly;width:2147483648px/height:-2147483649pxprint as the i32 bounds, which parse back to the same f32 as before (the old2147480000pxdid not).test/js/bun/css/(minus the local-only fuzz file) andtest/bundler/css/pass with the debug build.Background
<integer>values such asz-indexare i32 in browsers. f32 has a 24 bit mantissa, so it holds every integer only up to 16777216;2147483647is stored as2147483648.0. cssparser (and bun's port) therefore keep the exact integer next to the float in the token.dtoa_short(value, 6)is the float formatter lightningcss uses everywhere: shortest representation, then rounded to 6 significant digits (0.30000001prints as.3). Applied to an integer it zero-fills the remaining digits, which is where2147480000comes from.TokenListis the representation for custom properties and for any declaration bun cannot parse into a typed property; it is printed token by token, with numbers and dimensions going through the minifying number printers rather than the verbatim token printer.[review] gate passed · iteration 4 · 5 files touched
fails on main (without fix)
passes on PR (with fix)
diff hotspot
gate history · 2 passed · 0 rejected · iteration 4
evidence per changed file