Repository navigation
Bump WebKit to eeab04040fa6 (URLParser: SIMD scan for Unicode/percent-encoded hosts) - #39476
Jarred-Sumner wants to merge 1 commit into
Conversation
…r Unicode/percent host SIMD scan, oven-sh/WebKit#463) No-Verification-Needed: version pin bump
|
Updated 5:08 PM PT - Aug 17th, 2026
@Jarred-Sumner, your commit f696f01 is building: |
There was a problem hiding this comment.
LGTM — one-line WebKit pin bump.
What was reviewed:
prebuiltUrlprependsautobuild-when the version doesn't already start with it, so the full SHA resolves to theautobuild-eeab0404…release tag the description confirms is published.prebuiltDestDirslices non-autobuild-versions to 16 chars, so the cache dir key stays short and unique.- No other consumers of
WEBKIT_VERSION/cfg.webkitVersionbeyond these two paths.
Extended reasoning...
Overview
This PR changes exactly one line: the WEBKIT_VERSION constant in scripts/build/deps/webkit.ts, from an autobuild-preview-pr-455-* tag to the full 40-char SHA eeab04040fa6…. It is stacked on #39371 (the Bun-side changes for the underlying upstream upgrade); this PR's own diff is purely the pin.
Security risks
None from this diff. The constant feeds a GitHub release download URL and a local cache directory name — no user-controlled input, no parsing, no runtime code path. The behavioral changes (URLParser SIMD host scanning) live in oven-sh/WebKit#463 and were reviewed there.
Level of scrutiny
Low. This is a routine dependency pin bump — the recent git history shows several identical-shape WebKit bumps (#39368, the #39371 base). The only thing to verify in this repo is that the two consumers of cfg.webkitVersion handle a bare 40-char SHA correctly, which they do: prebuiltUrl conditionally prefixes autobuild-, and prebuiltDestDir conditionally truncates to 16 chars for the cache key. Both branches are exercised by this value.
Other factors
The PR description states the autobuild-eeab0404… release is already published with 42 assets, so the prebuilt download path won't 404. CI (#100244) will exercise the actual build against the new prebuilt. No CODEOWNERS on this file, no outstanding reviewer comments, no prior automated review on this PR.
|
Folding into #39371 instead. |
Pins WebKit to oven-sh/WebKit@eeab04040fa6 = the upstream
47f7250137c6upgrade (oven-sh/WebKit#455) plus oven-sh/WebKit#463 (URLParser: SIMD scan for percent-encoded/Unicode hosts, SIMD forbidden-host check, surrogate validation only when needed — IDN URLs 8176 → 7867 instr/URL).Stacked on #39371 (the Bun side of the upstream upgrade —
HandleSet.hremoval etc.), since #463 landed after #455 in oven-sh/WebKit; this PR's own diff is just the pin. GitHub will retarget it tomainwhen #39371 merges. Theautobuild-eeab0404…release is already published (42 assets).