Skip to content

Bump WebKit to eeab04040fa6 (URLParser: SIMD scan for Unicode/percent-encoded hosts) - #39476

Closed
Jarred-Sumner wants to merge 1 commit into
farm/89e31e51/webkit-upgrade-47f7250137c6from
claude/bump-webkit-eeab040
Closed

Jarred-Sumner wants to merge 1 commit into
farm/89e31e51/webkit-upgrade-47f7250137c6from
claude/bump-webkit-eeab040

Conversation

@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

Pins WebKit to oven-sh/WebKit@eeab04040fa6 = the upstream 47f7250137c6 upgrade (oven-sh/WebKit#455) plus oven-sh/WebKit#463 (URLParser: SIMD scan for percent-encoded/Unicode hosts, SIMD forbidden-host check, surrogate validation only when needed — IDN URLs 8176 → 7867 instr/URL).

Stacked on #39371 (the Bun side of the upstream upgrade — HandleSet.h removal etc.), since #463 landed after #455 in oven-sh/WebKit; this PR's own diff is just the pin. GitHub will retarget it to main when #39371 merges. The autobuild-eeab0404… release is already published (42 assets).

…r Unicode/percent host SIMD scan, oven-sh/WebKit#463)

No-Verification-Needed: version pin bump
@robobun

robobun commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator
Updated 5:08 PM PT - Aug 17th, 2026

@Jarred-Sumner, your commit f696f01 is building: #100244

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — one-line WebKit pin bump.

What was reviewed:

  • prebuiltUrl prepends autobuild- when the version doesn't already start with it, so the full SHA resolves to the autobuild-eeab0404… release tag the description confirms is published.
  • prebuiltDestDir slices non-autobuild- versions to 16 chars, so the cache dir key stays short and unique.
  • No other consumers of WEBKIT_VERSION / cfg.webkitVersion beyond these two paths.
Extended reasoning...

Overview

This PR changes exactly one line: the WEBKIT_VERSION constant in scripts/build/deps/webkit.ts, from an autobuild-preview-pr-455-* tag to the full 40-char SHA eeab04040fa6…. It is stacked on #39371 (the Bun-side changes for the underlying upstream upgrade); this PR's own diff is purely the pin.

Security risks

None from this diff. The constant feeds a GitHub release download URL and a local cache directory name — no user-controlled input, no parsing, no runtime code path. The behavioral changes (URLParser SIMD host scanning) live in oven-sh/WebKit#463 and were reviewed there.

Level of scrutiny

Low. This is a routine dependency pin bump — the recent git history shows several identical-shape WebKit bumps (#39368, the #39371 base). The only thing to verify in this repo is that the two consumers of cfg.webkitVersion handle a bare 40-char SHA correctly, which they do: prebuiltUrl conditionally prefixes autobuild-, and prebuiltDestDir conditionally truncates to 16 chars for the cache key. Both branches are exercised by this value.

Other factors

The PR description states the autobuild-eeab0404… release is already published with 42 assets, so the prebuilt download path won't 404. CI (#100244) will exercise the actual build against the new prebuilt. No CODEOWNERS on this file, no outstanding reviewer comments, no prior automated review on this PR.

@Jarred-Sumner

Copy link
Copy Markdown
Collaborator Author

Folding into #39371 instead.

@Jarred-Sumner
Jarred-Sumner deleted the claude/bump-webkit-eeab040 branch August 18, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants