Repository navigation
Bump WebKit to 2da33d53e33e - #40570
Conversation
Bytecode cache: build 1-3 character inline atoms from the slot's bytes, not from the loaded word (oven-sh/WebKit#519).
|
Warning Review limit reached
On-demand reviews are free for the next 25 days. After that, they cost $0.25 per reviewed file. Or wait 45 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 81 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
| * From https://github.com/oven-sh/WebKit releases. | ||
| */ | ||
| export const WEBKIT_VERSION = "76882271d74a6e7f5ca09db301d64302b1f4cd67"; | ||
| export const WEBKIT_VERSION = "2da33d53e33e71055d66f4b84537aa8cb0b0e99d"; |
There was a problem hiding this comment.
🟡 WebKit bump for a bytecode-cache bug fix ships without the regression test REVIEW.md requires
Extended reasoning...
REVIEW.md states "Every behavioral change ships an automated test in the same PR… even for one-liners. Crash fixes need the crashing input as a spawned fixture", and repo review instructions say checks REVIEW.md explicitly requests are not subjective. This bump pulls oven-sh/WebKit#519 ("build 1-3 character inline atoms from the slot's bytes, not from the loaded word"), a user-visible fix to --bytecode output — a bytecode-cached program whose constant pool contains 1–3-character atoms could deserialize the wrong string on the previous pin. Every recent WebKit bump in git log -- scripts/build/deps/webkit.ts (a3745c2, 7852665, 11fb730) paired the pin change with a test that fails on the old WebKit and passes on the new one; this PR changes only the hash. Relative to base, merging leaves the fixed behavior untested: a future WebKit merge that reintroduces the word-vs-slot read would pass CI. A correct fix adds a --bytecode test in test/bundler/bun-build-api.test.ts (or a regression file if there is a GitHub issue) that bundles a module with 1–3-char string…
Verification: nit — REVIEW.md (base-branch, binding) states: "Every behavioral change ships an automated test in the same PR. 'Verified manually', unnamed 'existing tests', and benchmarks don't count, even for one-liners. Crash fixes need the crashing input as a spawned fixture." The diff is exactly one line (scripts/build/deps/webkit.ts:6, WEBKIT_VERSION → 2da33d53…) and no test file is touched — the…
What does this PR do?
Bumps WebKit from
76882271d74ato2da33d53e33e— one commit:How did you verify your code works?
Release
autobuild-2da33d53e33e71055d66f4b84537aa8cb0b0e99dis published with all 42 prebuilt assets; CI builds against it.