Repository navigation
Conversation
…ip ci] Twelve programs for the engine change of oven-sh/WebKit#980: Object.create call sites whose classes would be each other's base, and a constructor function below a class that extends it. As an executable each one never returns on the engine that main pins, so CI is skipped until a pin holds that change. Two more programs hold rings that stay after that change. They are marked Todo, and their builds end with InvalidLayout under --aot-validate once the pin holds the change.
Collaborator
Author
|
Status
|
Collaborator
Author
Collaborator
|
Closing: #47942 rewrites the front end of the ahead-of-time compiler and its tests for the engine's new compiler (oven-sh/WebKit#997, merged), so this no longer applies and would conflict with it. If the problem still shows once that is in, please open a new pull request against |
Collaborator
Author
|
Understood. The problem does not show on the new compiler, so I open no new pull request.
If the programs are wanted as tests of this shape for the new compiler, say so here and I will open a pull request against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bun build --compile --aotexecutable never returns from a store into an object of a ten-line scope chain (objects/object-create-scope-chain-of-function-scopes-and-block-scopes.js). One thread stays at 100% CPU.bun runprints1 2 true false isFunction,x isFunction,y.Object.createcall sites classes, each the base of the other. The run time walks the classes below a class without a bound. [JSC] AOT: name no ring of base classes for Object.create call sites and constructor functions WebKit#980 is the fix. No program undertest/aot/parallelhas that shape.Fix
WEBKIT_VERSIONonmainthat holds [JSC] AOT: name no ring of base classes for Object.create call sites and constructor functions WebKit#980 or AOT: replace the flow passes and the B3 back end with a scan, a link and one walk WebKit#997. The diff has no pin. Until then CI fails on the twelve programs, because they never return on the engine thatmainpins today.test/aot/parallel. Each must print and exit as plain Bun does.// Todo:.mainpins, each of the twelve exits with 124 undertimeout 10. With [JSC] AOT: name no ring of base classes for Object.create call sites and constructor functions WebKit#980 on that engine,run-parallel.tspasses the twelve and skips the two (Notes). The same holds on the head of AOT: hangs, wrong answers, failed builds;bun test --aotfollows #44833's mocks #47605.Background
--aotcompiles a program to machine code. OneObject.create()call site makes a class, and the first object it is handed becomes the prototype object.run-parallel.tsbuilds each program undertest/aot/parallelwith--compile --aotand compares what the executable prints with plain Bun.// Todo:program is run and reported as skipped. It fails once it passes.Notes
The programs
"Before" is Bun
4f7acde0fwith the engine at4d45755fed, whichmainpins, as a user builds:bun build --compile --aot, thentimeout 10.objects/object-create-scope-chain-of-function-scopes-and-block-scopesobjects/object-create-places-in-a-ring-and-a-store-to-a-prototype-objectobjects/object-create-places-in-a-ring-and-a-property-deleted-from-a-prototype-objectdeleteobjects/object-create-places-in-a-ring-and-a-prototype-object-frozenObject.freezeobjects/object-create-places-in-a-ring-and-a-prototype-object-put-below-anotherObject.setPrototypeOfobjects/object-create-places-in-a-ring-closed-by-calls-in-a-loopobjects/object-create-places-in-a-ring-that-no-run-closesobjects/object-create-place-below-places-in-a-ringobjects/object-create-handed-the-prototype-object-of-another-placeobjects/object-create-handed-the-prototype-object-of-another-place-below-object-prototypeObject.prototypeobjects/object-create-hands-its-own-object-to-itself-and-then-to-another-placeconstructor-functions/prototype-object-made-below-that-of-a-class-that-extends-the-functionThe two
// Todo:programs are underclasses/. A cast names a base class there that closes a ring with the real one. With oven-sh/WebKit#980 their builds end withInvalidLayoutunder--aot-validate, which is the flag they carry. Without the flag the executable never returns. oven-sh/WebKit#980 says under "What stays" what would fix them.How it was run
4f7acde0fwith the engine at4d45755fedplus the change of [JSC] AOT: name no ring of base classes for Object.create call sites and constructor functions WebKit#980, both built from source, release:test/aot/run-parallel.tson the fourteen programs passes twelve and skips the two// Todo:programs.test/aot/parallel: 7172 pass, 12 are skipped by their own lines, 0 fail.bun test --aotfollows #44833's mocks #47605 (22621ef913, which pins the engineautobuild-preview-pr-982-648208de), release: each of the fourteen exits with 124 undertimeout 10.648208deplus the change of [JSC] AOT: name no ring of base classes for Object.create call sites and constructor functions WebKit#980, both built from source:run-parallel.tspasses twelve and skips the two// Todo:programs.main, with the same fourteen files.maintoday, so the programs were not built against the preview of [JSC] AOT: name no ring of base classes for Object.create call sites and constructor functions WebKit#980. Its own CI runs eleven IR text tests of the same shapes onmain.On the rewritten compiler
oven-sh/WebKit#997 and #47942 replace the part of the compiler that made the ring.
72ea3edb8, which pinsautobuild-preview-pr-997-30803ce0), release: the twelve programs print what plain Bun prints. Itsrun-parallel.tspasses the twelve and skips the two// Todo:programs.// Todo:programs fail to build there, because--aot-validateis no flag there. Built without it, both print what plain Bun prints.What happens next
When
mainpins an engine that holds oven-sh/WebKit#980, this branch is rebased and CI runs the programs on that engine. Ifmainpins the rewritten compiler first, the same happens, and the two// Todo:programs lose their// Flags:and// Todo:lines. On the engine thatmainpins today, CI ends each of the twelve at its time limit (90 s, 240 s with ASAN).