-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Improve Docker images #5771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Docker images #5771
Conversation
70de428 to
da9ed4f
Compare
|
Need to update GitHub actions, after that will be good to go. |
|
You should add
Source: https://everything.curl.dev/usingcurl/downloads/retry#tweak-your-retries This means:
Using the exponential backoff algorithm results in an overall delay of only 31 seconds. |
19965bb to
d77dd4a
Compare
| COPY --from=build /usr/local/bin/bun /usr/local/bin/ | ||
|
|
||
| # Known issue: `bunx` is not available in distroless. | ||
| # | ||
| # If `ln` is used in the build image, the size of the final | ||
| # image will be double, because of: https://github.com/oven-sh/bun/issues/5269 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPDATE: I opened a PR: #6090
You missed my comment?: #5269 (comment)
You can keep it:
# List of sources to destination (final path):
COPY --from=build \
/usr/local/bin/bun /usr/local/bin/bunx \
/usr/local/binComparision:
# Resolved with single COPY, symlink works:
$ docker save local-bun-build | gzip -c | wc -c | numfmt --to iec
40M
# The duplicate issue that previously existed:
$ docker save oven/bun | gzip -c | wc -c | numfmt --to iec
97M
# Resolved vs original image size:
$ docker images
REPOSITORY TAG IMAGE ID CREATED SIZE
local-bun-build latest 020acf83835e 7 minutes ago 110MB
oven/bun latest 647ebb4444b7 3 days ago 271MB
Closes #5269
Closes #4611
Closes #5454