fix: fixed wrong lms_host#1375
Merged
ahmed-arb merged 2 commits intooverhangio:releasefrom Apr 30, 2026
Merged
Conversation
Faraz32123
suggested changes
Apr 29, 2026
Contributor
Faraz32123
left a comment
Faraz32123
left a comment
There was a problem hiding this comment.
Can we also add the changelog entry?
Comment on lines
+11
to
+12
| if run_for_prod: | ||
| return |
Contributor
There was a problem hiding this comment.
isn't this condition redundant when we are already checking run_for_prod before calling the function.
| config, | ||
| run_for_prod=run_for_prod, | ||
| ) | ||
| elif run_for_prod is not None: |
Contributor
There was a problem hiding this comment.
nit: why didn't we specifically used elif not run_for_prod and remove the if condition from inside the function because it will return early from the function.
muhammadadeeltajamul
force-pushed
the
adeel/fix_wrong_lms_host
branch
2 times, most recently
from
548af34 to
651ffaf
Compare
Contributor
Author
It can be added in next release changelog |
muhammadadeeltajamul
force-pushed
the
adeel/fix_wrong_lms_host
branch
from
651ffaf to
e529070
Compare
Faraz32123
approved these changes
Apr 29, 2026
ahmed-arb
approved these changes
Apr 30, 2026
github-project-automation
Bot
moved this from In review
to Done
in Tutor project management
ahmed-arb
pushed a commit
that referenced
this pull request
Apr 30, 2026
3 tasks
ahmed-arb
added a commit
that referenced
this pull request
May 6, 2026
PR #1375 added an `elif not run_for_prod:` branch in `interactive_configuration` that called `set_run_mode_defaults`, unconditionally overwriting `LMS_HOST`, `CMS_HOST`, and `ENABLE_HTTPS` with development values whenever `run_for_prod` was falsy. For `tutor local launch --non-interactive`, `run_for_prod` is `None` (only `dev` sets it to `False`), which is also falsy — so the dev defaults clobbered the user's production configuration on every launch. CI deployments that ran `tutor config save --set LMS_HOST=...` followed by `tutor local launch -I` had those values silently reset, breaking HTTPS and the configured hostname. Address #1372 directly by changing the default `LMS_HOST` to `local.openedx.io`. A fresh `tutor dev launch -I` (or any first run with no prior config) now lands on dev-friendly defaults via the default values themselves — no special non-interactive code path needed. `CMS_HOST` already templates from `LMS_HOST`, and `ENABLE_HTTPS` was already `false` by default. Revert the `interactive_configuration` and `ask_questions` changes from #1375; the `set_run_mode_defaults` helper is no longer needed because the interactive "is this prod?" flow can inline its overrides as it did before. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ahmed-arb
added a commit
that referenced
this pull request
May 6, 2026
PR #1375 added an `elif not run_for_prod:` branch in `interactive_configuration` that called `set_run_mode_defaults`, unconditionally overwriting `LMS_HOST`, `CMS_HOST`, and `ENABLE_HTTPS` with development values whenever `run_for_prod` was falsy. For `tutor local launch --non-interactive`, `run_for_prod` is `None` (only `dev` sets it to `False`), which is also falsy — so the dev defaults clobbered the user's production configuration on every launch. CI deployments that ran `tutor config save --set LMS_HOST=...` followed by `tutor local launch -I` had those values silently reset, breaking HTTPS and the configured hostname. Address #1372 directly by changing the default `LMS_HOST` to `local.openedx.io`. A fresh `tutor dev launch -I` (or any first run with no prior config) now lands on dev-friendly defaults via the default values themselves — no special non-interactive code path needed. `CMS_HOST` already templates from `LMS_HOST`, and `ENABLE_HTTPS` was already `false` by default. Revert the `interactive_configuration` and `ask_questions` changes from #1375; the `set_run_mode_defaults` helper is no longer needed because the interactive "is this prod?" flow can inline its overrides as it did before. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix : Issue#1372
Fixes: Running
tutor dev launch -Isets defaultLMS_HOSTnotlocal.openedx.io