fix!: Raise exceptions when a plugin fails to load.#1377
fix!: Raise exceptions when a plugin fails to load.#1377xitij2000 wants to merge 1 commit intooverhangio:mainfrom
Conversation
|
Note this PR is to get the conversation started, we can improve the error messaging etc. |
|
@xitij2000 It looks like you can't disable the plugin using the command line after running into this problem. I could try modifying the config, but I can't ask it for the config root, either. Is it possible to keep this a warning for configuration commands but an error for things like image building and launching? |
I'll look into that. For now I just wanted to get some feedback. Is there is a reason to not do this at all? Or move it to a separate command or plugin. |
When a plugin is missing or throws an error while loading, Tutor continues as normal. At times this has made us recognise issues far later than we'd like.
This change will raise an error causing the command to return an error and the break the CI flow rather than deploying a broken instance with missing plugins.
We've considered few alternatives.
--check, however this flag would need to be added in a lot of places that cause plugins to load.tutor doctorthis is a convention that many such tools follow that check the config and environment for errors and suggest fixes. This issue with this is that it will require updating existing usage of tutor to call tutor doctor first.