Fix tests on FreeBSD #1973
Closed
Fix tests on FreeBSD #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeBSD has different prefix for bash (which is non-standard shell there), thus "make check-TESTS" actually was doing nothing: $ gmake check-TESTS ( 0/ 0/ 0): test/test-cases/regression/issue-1591.json ( 0/ 0/ 0): test/test-cases/regression/issue-1785.json ( 0/ 0/ 0): test/test-cases/regression/issue-1812.json ( 0/ 0/ 0): test/test-cases/regression/issue-1831.json ( 0/ 0/ 0): test/test-cases/regression/issue-1844.json ( 0/ 0/ 0): test/test-cases/regression/issue-1850.json [..] Testsuite summary for modsecurity 3.0
|
...and of course it does not break anything on Linuxes. |
zimmerle
pushed a commit
that referenced
this pull request
Dec 4, 2018
|
Merged! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD has different prefix for bash (which is non-standard shell there), thus
make check-TESTSactually was doing nothing:This change allows to run libmodsecurity tests on FreeBSD if bash is installed.