Fix LMDB compilation #2011
Closed
Fix LMDB compilation #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMBD is not built by default since 6143eb9, so add explicit --with-lmdb configuration. Missing --with-lmdb build allowed a bug in PR owasp-modsecurity#2003 to pass through, causing issue owasp-modsecurity#2008.
Bug introduced in ad28de4. Fixes owasp-modsecurity#2008.
When LMDB is enabled, ModSecurity stores its persistent variables in "./modsec-shared-collections" file. Since this file wasn't cleared between tests, tests behaved differently on "in-memory per-process" and LMDB backend. This test never worked in LMDB configuration. It hasn't been discovered until now because Travis CI didn't test LMDB configuration when test was introduced.
|
Thank you for your contribution. We don't encourage users to use LMDB. It is there for advanced users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2008
When I re-enabled LMDB testing in Travis, I also discovered a regression test that fails when LMDB is enabled, and fixed it as well. The fix is ugly, but so is the LMDB backend code that stores data in hardcoded location relative to the current working dir
¯\_(ツ)_/¯.