Use nginx's parsed hostname #950
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimmerle
pushed a commit
that referenced
this pull request
Dec 10, 2015
zimmerle
pushed a commit
that referenced
this pull request
Dec 10, 2015
|
Hi @TrungACZNE, Thank you for your patch! The code is now on the hands of our Buildbots. |
|
Thanks again @TrungACZNE! Your patch is now merge into nginx_refactoring branch. |
zimmerle
pushed a commit
that referenced
this pull request
Feb 1, 2016
zimmerle
pushed a commit
that referenced
this pull request
Feb 1, 2016
zimmerle
pushed a commit
that referenced
this pull request
Feb 2, 2016
zimmerle
pushed a commit
that referenced
this pull request
Feb 2, 2016
zimmerle
pushed a commit
that referenced
this pull request
Feb 2, 2016
zimmerle
pushed a commit
that referenced
this pull request
Feb 2, 2016
daniilyar
pushed a commit
to daniilyar/ModSecurity
that referenced
this pull request
Feb 5, 2016
daniilyar
pushed a commit
to daniilyar/ModSecurity
that referenced
this pull request
Feb 5, 2016
…iable before use it
chewi
pushed a commit
to yakara-ltd/ModSecurity
that referenced
this pull request
May 2, 2016
chewi
pushed a commit
to yakara-ltd/ModSecurity
that referenced
this pull request
May 2, 2016
…iable before use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the module the request structure's hostname is assigned by ngx_cycle->hostname, which in turn is assigned gethostname(). I don't understand why this is the case, it's not the same as the
Hostheader which tells which virtual host is being targeted by the request.This pull request uses nginx's parsed
Hostheader for req->hostname instead.