Skip to content

fix: do not consider relational operators and multiple comparisons#596

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-16-fix_do_not_consider_relational_operators_and_multiple_comparisons
Jan 24, 2026
Merged

fix: do not consider relational operators and multiple comparisons#596
graphite-app[bot] merged 1 commit intomainfrom
01-16-fix_do_not_consider_relational_operators_and_multiple_comparisons

Conversation

@camchenry
Copy link
Copy Markdown
Member

@camchenry camchenry commented Jan 17, 2026

This code was partially written by AI. The original rule source rules out these tokens right away and should fix the false positives above.

Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add the label 0-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry marked this pull request as ready for review January 17, 2026 04:25
@camchenry camchenry requested a review from camc314 January 17, 2026 04:33
@camchenry camchenry force-pushed the 01-16-fix_do_not_consider_relational_operators_and_multiple_comparisons branch from fbbbc96 to 2e49f9f Compare January 19, 2026 00:47
@connorshea connorshea requested a review from Boshen January 23, 2026 07:32
@connorshea
Copy link
Copy Markdown
Member

@Boshen probably a good idea to get this merged if we can

Copy link
Copy Markdown
Member Author

camchenry commented Jan 24, 2026

Merge activity

)

- fixes oxc-project/oxc#18110
- fixes oxc-project/oxc#17968

This code was partially written by AI. The original rule source rules out these tokens right away and should fix the false positives above.
@graphite-app graphite-app Bot force-pushed the 01-16-fix_do_not_consider_relational_operators_and_multiple_comparisons branch from 2e49f9f to 816e304 Compare January 24, 2026 02:27
@camchenry camchenry added 0-merge and removed 0-merge labels Jan 24, 2026
@graphite-app graphite-app Bot merged commit 816e304 into main Jan 24, 2026
7 of 8 checks passed
@graphite-app graphite-app Bot deleted the 01-16-fix_do_not_consider_relational_operators_and_multiple_comparisons branch January 24, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: Typescript-eslint(prefer-optional-chain) false positive linter: typescript-eslint(prefer-optional-chain) false positives and wrong fixes

2 participants