Skip to content

builder takes _BL_SPACE too seriously in boot images #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wesolows opened this issue Apr 28, 2022 · 0 comments · May be fixed by #13
Open

builder takes _BL_SPACE too seriously in boot images #11

wesolows opened this issue Apr 28, 2022 · 0 comments · May be fixed by #13

Comments

@wesolows
Copy link
Contributor

Currently we test that an ELF boot image has a _BL_SPACE symbol and that its value is exactly equal to the amount of space occupied by (in effect) everything below the base of the BSS. Normally this is fine, but it's needlessly restrictive: if there's extra space allocated that's unused -- in sufficient quantity that it causes us to allocate unnecessary space beyond __ebss -- then we fail with an IncompatibleExecutable error. In fact this is harmless and we could test only to see whether totalsz <= symsz.

daym added a commit that referenced this issue Apr 28, 2022
@daym daym linked a pull request Apr 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant