Skip to content

main: Relax ELF loader space check. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

main: Relax ELF loader space check. #13

wants to merge 1 commit into from

Conversation

daym
Copy link
Collaborator

@daym daym commented Apr 28, 2022

Fixes #11.

@daym daym requested a review from wesolows April 28, 2022 23:09
wesolows
wesolows approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@wesolows wesolows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right. Testing can be accomplished, if you haven't already done so, by setting _BL_SPACE to 512K; the resulting boot image will not work with the existing code. Thanks!

@daym
Copy link
Collaborator Author

daym commented May 16, 2022 •
edited
Loading

Dan Cross said that this doesn't always work, so I'm delaying the merge.

Dan:

Btw, I tested amd-image-builder with your change and it fails for images >256KiB.
So, for instance, if I set _BL_SPACE to 260k, I get an incompatible image error.

@daym daym marked this pull request as draft June 15, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesolows wesolows wesolows approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

builder takes _BL_SPACE too seriously in boot images
2 participants
@daym @wesolows