Skip to content

Add side modal heading #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Conversation

benjaminleonard
Copy link
Contributor

@benjaminleonard benjaminleonard commented Nov 6, 2024

https://console-git-side-modal-title-oxidecomputer.vercel.app/projects/mock-project/vpcs/mock-vpc/firewall-rules-new


Added SideModal.Heading – example usage on Firewall Rules side modal to be used also within #2511.

image

The size looks good to me, making it semi seems to have made the difference in distinguishing it.

Also in terms of usage – I think a heading should always be preceded by a divider, things are going to get messy if we drop it in to group inputs willy nilly.

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Nov 6, 2024 4:09pm

<ProtocolField control={control} protocol="TCP" />
<ProtocolField control={control} protocol="UDP" />
<ProtocolField control={control} protocol="ICMP" />
</fieldset>

<div className="flex flex-col gap-3">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stuff is unnecessary because the overall thing already has the spacing, it also causes a bit of havok since the spacing here is different.

@david-crespo david-crespo merged commit 6e17d29 into recombobulate-idp-form Nov 6, 2024
8 checks passed
@david-crespo david-crespo deleted the side-modal-title branch November 6, 2024 16:47
david-crespo added a commit that referenced this pull request Nov 6, 2024
* Reorder IDP create form elements

* Update edit form order

* Add docs link for Identity Providers

* Remove checkbox for Signed Requests

* Add side modal heading (#2533)

* Add side modal heading

* Remove commented input legend

* very important mt-2

* cut one word to cut a whole line out of the targets info box

---------

Co-authored-by: David Crespo <[email protected]>

* change form section headings to SideModal.Heading, remove "General"

---------

Co-authored-by: Benjamin Leonard <[email protected]>
Co-authored-by: David Crespo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants