Fix radix warnings on side modal #2536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Nov 7, 2024
| )} | ||
| </> | ||
| <div className="items-top mb-4 mt-8"> | ||
| <Dialog.Title className="flex w-full items-center justify-between break-words pr-8 text-sans-2xl"> |
There was a problem hiding this comment.
Dialog.Title without asChild renders as an h2. Putting it directly around the title itself makes a lot more sense here.
david-crespo
commented
Nov 7, 2024
| @@ -30,7 +30,7 @@ export function usePopoverZIndex() { | |||
| } | |||
|
|
|||
| export type SideModalProps = { | |||
| title?: string | |||
| title: string | |||
There was a problem hiding this comment.
Title did not need to be optional. We always have a title.
david-crespo
commented
Nov 7, 2024
| @@ -53,7 +53,6 @@ export function SideModal({ | |||
| animate = true, | |||
| errors, | |||
| }: SideModalProps) { | |||
| const titleId = 'side-modal-title' | |||
There was a problem hiding this comment.
This was used to hook up the accessible title to the dialog, but Radix takes care of that for us.
david-crespo
commented
Nov 7, 2024
| title={errors.length > 1 ? 'Errors' : 'Error'} | ||
| /> | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
why were errors inside the title????
david-crespo
commented
Nov 7, 2024
| } | ||
| title={errors.length > 1 ? 'Errors' : 'Error'} | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
I confirmed everything looks the same as main when there are errors.
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 10, 2024
oxidecomputer/console@6eeab20...9ef82ba * [9ef82bad](oxidecomputer/console@9ef82bad) oxidecomputer/console#2529 * [23beefea](oxidecomputer/console@23beefea) oxidecomputer/console#2537 * [48693a22](oxidecomputer/console@48693a22) oxidecomputer/console#2510 * [8da7b6d0](oxidecomputer/console@8da7b6d0) oxidecomputer/console#2539 * [5edf89ef](oxidecomputer/console@5edf89ef) oxidecomputer/console#2536 * [dcddc81f](oxidecomputer/console@dcddc81f) oxidecomputer/console#2538 * [6f83d416](oxidecomputer/console@6f83d416) oxidecomputer/console#2518 * [7dcd41c2](oxidecomputer/console@7dcd41c2) oxidecomputer/console#2511 * [b01ca85d](oxidecomputer/console@b01ca85d) bump omicron to latest main * [b4920b11](oxidecomputer/console@b4920b11) oxidecomputer/console#2530 * [0552b62e](oxidecomputer/console@0552b62e) oxidecomputer/console#2527 * [ca7f6e20](oxidecomputer/console@ca7f6e20) oxidecomputer/console#2528
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Nov 10, 2024
oxidecomputer/console@6eeab20...9ef82ba * [9ef82bad](oxidecomputer/console@9ef82bad) oxidecomputer/console#2529 * [23beefea](oxidecomputer/console@23beefea) oxidecomputer/console#2537 * [48693a22](oxidecomputer/console@48693a22) oxidecomputer/console#2510 * [8da7b6d0](oxidecomputer/console@8da7b6d0) oxidecomputer/console#2539 * [5edf89ef](oxidecomputer/console@5edf89ef) oxidecomputer/console#2536 * [dcddc81f](oxidecomputer/console@dcddc81f) oxidecomputer/console#2538 * [6f83d416](oxidecomputer/console@6f83d416) oxidecomputer/console#2518 * [7dcd41c2](oxidecomputer/console@7dcd41c2) oxidecomputer/console#2511 * [b01ca85d](oxidecomputer/console@b01ca85d) bump omicron to latest main * [b4920b11](oxidecomputer/console@b4920b11) oxidecomputer/console#2530 * [0552b62e](oxidecomputer/console@0552b62e) oxidecomputer/console#2527 * [ca7f6e20](oxidecomputer/console@ca7f6e20) oxidecomputer/console#2528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In local dev, Radix was giving a spurious error and a technically true but pointless warning on our side modal. This PR gets rid of both.