Skip to content

Fail to build if tasks may overflow #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkeeter merged 10 commits into from
Oct 9, 2024
Merged

Fail to build if tasks may overflow #1890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b836a35
Fail to build if tasks may overflow
mkeeter Oct 2, 2024
f9b986c
Bump CPA stack size for Gimletlet
mkeeter Oct 2, 2024
5063534
Bump ping's stack size as well
mkeeter Oct 2, 2024
d15ba46
Slight reorganization
mkeeter Oct 2, 2024
ffda419
Don't try to decode data sections
mkeeter Oct 2, 2024
c511f32
Switch to Capstone, since we use weird instructions
mkeeter Oct 2, 2024
143844f
Fix recursion, add verbose printing
mkeeter Oct 2, 2024
f960090
Lots of reorganization and commenting
mkeeter Oct 2, 2024
aea4471
Add stack details to `xtask sizes` as well
mkeeter Oct 9, 2024
9471544
Add some comments to stack helper functions
mkeeter Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ bitflags = { version = "2.5.0", default-features = false }
bstringify = { version = "0.1.2", default-features = false }
byteorder = { version = "1.3.4", default-features = false }
bzip2-rs = { version = "0.1.2", default-features = false }
capstone = { version = "0.12.0", default-features = false, features = ["full"] }
cargo_metadata = { version = "0.12.0", default-features = false }
cfg-if = { version = "1", default-features = false }
chrono = { version = "0.4", default-features = false }
Expand Down Expand Up @@ -70,6 +71,7 @@ hubpack = { version = "0.1.2", default-features = false }
indexmap = { version = "1.4.0", default-features = false, features = ["serde-1"] }
indoc = { version = "2.0.3", default-features = false }
itertools = { version = "0.10.5", default-features = false }
leb128 = { version = "0.2.5", default-features = false }
lpc55-pac = { version = "0.4", default-features = false }
memchr = { version = "2.4", default-features = false }
memoffset = { version = "0.6.5", default-features = false }
Expand All @@ -90,6 +92,7 @@ rand_core = { version = "0.6", default-features = false }
rangemap = { version = "1.3", default-features = false }
regex = { version = "1", default-features = false, features = ["std", "perf", "unicode-perl"] }
ron = { version = "0.8", default-features = false }
rustc-demangle = { version = "0.1.24", default-features = false }
scroll = { version = "0.10", default-features = false }
serde = { version = "1.0.114", default-features = false, features = ["derive"] }
serde-big-array = { version = "0.4", default-features = false }
Expand Down
4 changes: 2 additions & 2 deletions app/demo-stm32g0-nucleo/app-g070.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ stacksize = 256
name = "task-ping"
features = ["uart", "no-ipc-counters"]
priority = 4
max-sizes = {flash = 8192, ram = 512}
stacksize = 256
max-sizes = {flash = 8192, ram = 1024}
stacksize = 512
start = true
task-slots = [{peer = "pong"}, "usart_driver"]

Expand Down
2 changes: 1 addition & 1 deletion app/gimletlet/app.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ tasks = ["control_plane_agent", "caboose_reader"]
name = "task-control-plane-agent"
priority = 7
max-sizes = {flash = 131072, ram = 32768}
stacksize = 4096
stacksize = 6000
start = true
uses = ["usart1"]
task-slots = [
Expand Down
3 changes: 3 additions & 0 deletions build/xtask/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ toml_edit = { workspace = true }
# for dist
byteorder = { workspace = true }
bzip2-rs = { workspace = true }
capstone = { workspace = true }
ctrlc = { workspace = true }
dunce = { workspace = true }
filetime = { workspace = true }
Expand All @@ -25,6 +26,7 @@ goblin = { workspace = true }
hex = "0.4"
hubtools = { workspace = true }
indexmap = { workspace = true }
leb128 = { workspace = true }
multimap = { workspace = true }
path-slash = { workspace = true }
rangemap = { workspace = true }
Expand All @@ -34,6 +36,7 @@ scroll = { workspace = true }
serde = { workspace = true }
serde_json = { workspace = true }
sha3 = { workspace = true }
rustc-demangle = { workspace = true }
tlvc = { workspace = true }
tlvc-text = { workspace = true }
toml = { workspace = true }
Expand Down
1 change: 1 addition & 0 deletions build/xtask/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,7 @@ impl BuildConfig<'_> {
// nightly features that we use:
nightly_features.extend([
"asm_const",
"emit_stack_sizes",
"naked_functions",
"used_with_arg",
]);
Expand Down
Loading