Repository navigation
Miscellaneous Cleanups For The FM Subsystem #10869
Description
I'm using this as a bit of a staging ground for things that are, IMO, pretty easy clean-up changes, but invasive enough that I don't want to do them as a part of other FM-related changes.
- https://github.com/oxidecomputer/omicron/pull/10592/changes#r3606250554 - use a macro for "expecting columns" from kinded fact types.
- https://github.com/oxidecomputer/omicron/pull/10592/changes#r3606101391 - Split out fact-types in a per-DE module
- [datastore] impl Selectable and Queryable for Saga #10866 + https://github.com/oxidecomputer/omicron/pull/10592/changes#r3606255152 - Change
SagaSummaryto use theSelectable/Queryablemodel. - https://github.com/oxidecomputer/omicron/pull/10592/changes#r3606347834 - it would be nice to either proptest or exhaustively iterate over "all DEs, all facts" and see that foreign facts get treated consistently (the case gets closed)
- [fm] Add disk diagnoser with typed fact tables #10541 (comment) - Derive macros for DB models / sitrep types to ensure they have the necessary ID types to be contained within a sitrep (and GC'd from a sitrep that gets deleted too)
- https://github.com/oxidecomputer/omicron/pull/10592/changes#r3606457099 - Parallelize planning input loading
Activity
hawkw commentedon Jul 20, 2026
Another idea to include here is a derive macro similar to
#[derive(Identity)]for DB models for sitrep member types (and perhaps one specifically for facts?) that ensures they always have the various ID columns required to be part of a sitrep. This is something we originally discussed over here: #10541 (comment) and decided was a good idea, but better saved for once we have enough fact record models for it to be worth the effort.