Skip to content

omdb warning when expunging sleds could use an update #11670

Open

Description

@davepacheco

I was doing some expunge/re-add testing in #11638 and ran into this warning:

WARNING: sled af2c58b7-e6d3-4805-8969-7715fd108a8b is PRESENT in the most recent inventory collection (spotted at 2026-11-03 00:29:12.430433 UTC). It is dangerous to expunge a sled that is still running. Are you sure you want to proceed anyway?

This warning was written at a time when the expungement process did not kick a sled out of trust quorum and reboot it. The expectation was that you would physically power it off or remove the sled and then we'd stop seeing it in inventory. And we were afraid that if you hadn't done this, then there might be some components still running there and that would be very bad. But with the TQ integration, it's sufficient to kick it out and then reboot it -- now we know there are no components running.

I'm not sure if omdb could actually know this. And it does rely on having already done the TQ removal. A person might have gotten that wrong.

All of this is somewhat moot in that we're building fuller automation around all of this under RFD 747. But if we keep this command to run this small part of it, then we should consider:

  • having the command check whether the sled has already been removed from TQ (it should have been)
  • editing the warning to better communicate the actual requirement here. (It might be better if it looked only for the sled agent being present in the inventory, which would still be a red flag. But presence of the SP is not a red flag.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions