Repository navigation
Add metrics representing silo quota limits and utilization. #11500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -138,7 +138,7 @@ impl DataStore { | |
| } | ||
|
|
||
| /// Create a project in the given silo. | ||
| async fn project_create_in_silo( | ||
| pub async fn project_create_in_silo( | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know you're making this pub for a test, but it's doing the same thing as This seems a little sketchy to expose as
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reverting. I wound up creating a test user and giving it silo access, which is boilerplate I was trying to avoid, but seems better than changing method access just for the test. |
||
| &self, | ||
| opctx: &OpContext, | ||
| project: Project, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turbo nit: perhaps: