Repository navigation
[trust-quorum] tla: let the coordinator receive its own commit - #11601
Draft
sunshowers wants to merge 1 commit into
Draft
sunshowers wants to merge 1 commit into
sunshowers wants to merge 1 commit into
Conversation
Contributor
Author
|
We need to optimize the TLA+ model quite significantly before this can be landed. Working on a stack for this. The previous commit in the stack, #11600, can be landed regardless. |
sunshowers
marked this pull request as draft
October 27, 2026 23:41
Base automatically changed from
sunshowers/spr/trust-quorum-tla-download-jar-add-checksh-and-add-a-no-crash-model-exposing-a-model-bug
to
main
October 29, 2026 20:35
sunshowers
force-pushed
the
sunshowers/spr/trust-quorum-tla-let-the-coordinator-receive-its-own-commit
branch
from
October 29, 2026 20:35
3e4290c to
c89aa8f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in the
RecvCommitstate, the coordinator only accepted a commit when the node wasIdleorUncommitted. Update the TLA+ model to permit a transition from theCoordinatePreparestate as well.The actual implementation is fine -- it was just the model that had this bug in it. (The bug was being masked by the previously-only config having n1 in its crash set.)