Skip to content

Turin Dense is as valid as Turin for VM placement #11668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iximeow merged 6 commits into from
Nov 3, 2026
Merged

Turin Dense is as valid as Turin for VM placement #11668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a48c3de
Turin Dense is as valid as Turin for VM placement
iximeow Nov 3, 2026
f305ed7
Make instance update test code less dizzying
iximeow Nov 3, 2026
067f52d
Add a test helper for expected instance/sled placement
iximeow Nov 3, 2026
0c45c3f
clippy...
iximeow Nov 3, 2026
2bd8e83
grammar better
iximeow Nov 3, 2026
e179db5
the boot disk uuid should be compared to a uuid, not the original name
iximeow Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions nexus/db-model/src/instance_cpu_platform.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,17 @@ impl InstanceCpuPlatform {
match self {
// Turin-based sleds have a superset of the features made available
// in a guest's Milan CPU platform
Self::AmdMilan => {
&[SledCpuFamily::AmdMilan, SledCpuFamily::AmdTurin]
Self::AmdMilan => &[
SledCpuFamily::AmdMilan,
SledCpuFamily::AmdTurin,
SledCpuFamily::AmdTurinDense,
],
Self::AmdTurin => {
&[SledCpuFamily::AmdTurin, SledCpuFamily::AmdTurinDense]
}
Self::AmdTurinV2 => {
&[SledCpuFamily::AmdTurin, SledCpuFamily::AmdTurinDense]
}
Self::AmdTurin => &[SledCpuFamily::AmdTurin],
Self::AmdTurinV2 => &[SledCpuFamily::AmdTurin],
Comment on lines -41 to -42

@hawkw hawkw Nov 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. lmao.

}
}
}
Expand Down
Loading
Loading