Repository navigation
Conversation
hawkw
force-pushed
the
eliza/move-the-unregister-stuff-into-saga-helpers
branch
2 times, most recently
from
November 4, 2026 19:29
6721869 to
02f9896
Compare
hawkw
marked this pull request as ready for review
November 4, 2026 19:36
karencfv
reviewed
Nov 5, 2026
| "sled_id" => sled_id.to_string(), | ||
| )); | ||
|
|
||
| // `ensure_vmm_unregistered` will not retry errors checking if the sled is |
Contributor
There was a problem hiding this comment.
Suggested change
| // `ensure_vmm_unregistered` will not retry errors checking if the sled is | |
| // `ensure_vmm_unregistered` will not retry error checking if the sled is |
| // about it will ever see any evidence of its existence anyway! | ||
| // We can now safely proceed to telling the sled-agent to disown | ||
| // it. | ||
| Err(Error::ObjectNotFound { .. }) => {} |
Contributor
There was a problem hiding this comment.
Doesn't hurt to add Error::Gone and Error::NotFound for future-proofing
| // If the sled no longer exists in the database at all, that's...quite | ||
| // surprising! But, we can hopefully assume that the sled, and any VMMs | ||
| // running on it, no longer exist. | ||
| Err(Error::ObjectNotFound { |
`ensure_vmm_unregistered`
hawkw
force-pushed
the
eliza/move-the-unregister-stuff-into-saga-helpers
branch
from
November 6, 2026 23:52
02f9896 to
a15da41
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11696 added enough additional code to the
sis_ensure_unregisteredunwinding action in theinstance_startsaga that it felt like the easiest way to propagate the same changes to theinstance_migratesaga's unwinding actions was to move all of it into the shared helper. This PR does that. I figured it was a bit nicer to do this in a follow up branch to try and keep the already-giant diff in #11696 a little more manageable.