Repository navigation
Cleanup: Remove SwitchPortSettingsGroups - #11711
Draft
internet-diglett wants to merge 1 commit into
Draft
internet-diglett wants to merge 1 commit into
internet-diglett wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the removal of the unused switch port settings groups feature.
No open issues 🎉
What changed in this PR
Removes the unused, partially implemented switch port settings groups feature from Nexus’s API types and database layer, while preserving older API response formats through version adapters.
Changes:
- Introduces an API version without
groupsand updates the OpenAPI definitions. - Removes group models, schema declarations, and unused fields from callers and tests.
- Adds migrations to drop both group tables and advances the database schema to version 313.
| File | Description |
|---|---|
schema/crdb/remove-port-settings-groups/up2.sql |
Drops the group definition table. |
schema/crdb/remove-port-settings-groups/up1.sql |
Drops the settings-to-group mapping table. |
schema/crdb/dbinit.sql |
Removes group tables and updates the schema version. |
openapi/nexus/nexus-2026110500.0.0-938342.json |
Defines the new API version without groups. |
openapi/nexus/nexus-2026110200.0.0-ff43bc.json.gitstub |
References the previous OpenAPI document. |
nexus/types/versions/src/remove-port-settings-groups/networking.rs |
Adds group-free types and backward-compatible conversions. |
nexus/types/versions/src/remove-port-settings-groups/mod.rs |
Exposes the new networking types module. |
nexus/types/versions/src/lib.rs |
Registers the new type version. |
nexus/types/versions/src/latest.rs |
Exports the new types as latest. |
nexus/types/versions/src/impls/networking.rs |
Removes group initialization from defaults. |
nexus/src/app/rack.rs |
Removes group initialization during rack setup. |
nexus/external-api/src/lib.rs |
Adds versioned endpoints and older-version adapters. |
nexus/db-schema/src/schema.rs |
Removes Diesel declarations for both group tables. |
nexus/db-queries/src/db/datastore/switch_port.rs |
Removes group fields, conversions, and obsolete test assertions. |
nexus/db-model/src/switch_port.rs |
Removes group models and their conversions. |
nexus/db-model/src/schema_versions.rs |
Registers schema version 313 and its migration directory. |
Review effort: Balanced
internet-diglett
marked this pull request as draft
November 6, 2026 17:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This configuration parameter was never actually used or fully implemented.