Use ClickHouse native client to read database tables #7016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bnaecker
commented
Nov 8, 2024
bnaecker
commented
- Most of the work to use the native client during schema updates was already done in Read / write timeseries schema with the native client #6943. One annoyingly small exception is the code that lists the tables in the database, which we use for expunging old timeseries schema from all the relevant tables. This switches to using the native client to list tables too.
- Fixes ClickHouse schema updates still use the HTTP client #7015
- Most of the work to use the native client during schema updates was already done in #6943. One annoyingly small exception is the code that lists the tables in the database, which we use for expunging old timeseries schema from all the relevant tables. This switches to using the native client to list tables too. - Fixes #7015
bnaecker
force-pushed
the
use-native-client-for-schema-updates
branch
from
c4ed11a to
6d6589d
Compare
smklein
reviewed
Nov 8, 2024
smklein
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.