Skip to content

[mgs] API for ingesting ereports from SPs #7903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 52 commits into from
May 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
ba42796
[ereport] index ereport ingestion by SP type/slot
hawkw Apr 1, 2025
cb673ec
we're calling them "restart IDs" now
hawkw Apr 1, 2025
8d66c09
whoopsie...
hawkw Apr 1, 2025
df3a493
unused variables
hawkw Apr 1, 2025
731966a
regenerate golden file
hawkw Apr 2, 2025
e324481
less structured ereport type
hawkw Apr 2, 2025
4cf9246
update mgs dep
hawkw Apr 3, 2025
49973ae
track unrelated mgs changes (factor me out pls)
hawkw Apr 3, 2025
20863c6
plumbing
hawkw Apr 3, 2025
f941a08
sp-sim plumbing
hawkw Apr 3, 2025
d1cd98b
wire up api (poorly)
hawkw Apr 3, 2025
a45ff03
demo hour
hawkw Apr 4, 2025
ff56b84
update for gatway fix
hawkw Apr 4, 2025
e69fc91
put fake interface in logs
hawkw Apr 4, 2025
f250ded
actually good errors
hawkw Apr 4, 2025
7d53fdb
pick up gateway messages tweaks
hawkw Apr 5, 2025
d1738a7
simulator improvements
hawkw Apr 5, 2025
7cc88ea
add ereports to sim sidecar
hawkw Apr 5, 2025
d481e21
hakari
hawkw Apr 5, 2025
619ccf4
give them both something to say
hawkw Apr 5, 2025
914dcd4
update MGS
hawkw Apr 7, 2025
539b0ce
honor limit
hawkw Apr 8, 2025
46c3612
update SP simulator
hawkw Apr 9, 2025
a7905e0
rm unused import
hawkw Apr 9, 2025
02b65b2
pass through ereport addrs in gateway-test-utils
hawkw Apr 10, 2025
64fd8f3
update to pick up request IDs from MGS
hawkw Apr 10, 2025
24b009b
simple ereport ingestion integration test
hawkw Apr 10, 2025
fea3438
so it turns out i'm stupid. fix that.
hawkw Apr 10, 2025
69a6c0a
add some simple ereport integration tests
hawkw Apr 11, 2025
4dd8878
pick up latest gateway-sp-comms
hawkw Apr 11, 2025
7ebf1d6
Merge branch 'main' into eliza/ereport-sp-api
hawkw Apr 11, 2025
7ea4ef3
fix sim mgs/sp SMF configs missing ereport addrs
hawkw Apr 12, 2025
9af73b6
update & track gateway-messages changes
hawkw Apr 15, 2025
0ff4977
unsandwich ENAs
hawkw Apr 17, 2025
b71609c
Merge branch 'main' into eliza/ereport-sp-api
hawkw Apr 28, 2025
f245a3f
update to track sp-sim changes from #8055
hawkw Apr 28, 2025
286bf61
Merge branch 'main' into eliza/ereport-sp-api
hawkw May 12, 2025
542ea63
who up managing they gateway service
hawkw May 12, 2025
645c4de
oof ouch oh no agh ouch ow
hawkw May 12, 2025
8eccf7b
PAIN
hawkw May 12, 2025
451a12e
fix ena type conversion
hawkw May 13, 2025
dd179e4
factor out udp bits
hawkw May 13, 2025
19b7cd0
cleanup imports
hawkw May 13, 2025
178dcef
more cleanup
hawkw May 13, 2025
2d09c6f
ENAs start at 1 now
hawkw May 13, 2025
9cb27a8
ENAs start at 1 now (across restarts)
hawkw May 13, 2025
aaa3c37
hakari update
hawkw May 13, 2025
2ecfb47
@cbiffle review feedback
hawkw May 13, 2025
fe5d3ca
nicer SP simulator logging
hawkw May 13, 2025
4bf8937
update api (oops)
hawkw May 13, 2025
04d967e
Update package-manifest.toml
hawkw May 13, 2025
368f84f
oh god i picked the wrong one of the three shas lol
hawkw May 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 63 additions & 55 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 6 additions & 8 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ members = [
"clients/cockroach-admin-client",
"clients/ddm-admin-client",
"clients/dns-service-client",
"clients/ereport-client",
"clients/gateway-client",
"clients/installinator-client",
"clients/nexus-client",
Expand Down Expand Up @@ -53,7 +52,6 @@ members = [
"dns-server",
"dns-server-api",
"end-to-end-tests",
"ereport/api",
"ereport/types",
"gateway",
"gateway-api",
Expand Down Expand Up @@ -164,7 +162,6 @@ default-members = [
"clients/cockroach-admin-client",
"clients/ddm-admin-client",
"clients/dns-service-client",
"clients/ereport-client",
"clients/gateway-client",
"clients/installinator-client",
"clients/nexus-client",
Expand Down Expand Up @@ -206,7 +203,6 @@ default-members = [
"dns-server",
"dns-server-api",
"end-to-end-tests",
"ereport/api",
"ereport/types",
"gateway",
"gateway-api",
Expand Down Expand Up @@ -419,8 +415,6 @@ dpd-client = { git = "https://github.com/oxidecomputer/dendrite" }
dropshot = { version = "0.16.0", features = [ "usdt-probes" ] }
dyn-clone = "1.0.19"
either = "1.14.0"
ereport-api = { path = "ereport/api" }
ereport-client = { path = "clients/ereport-client" }
ereport-types = { path = "ereport/types" }
expectorate = "1.2.0"
fatfs = "0.3.6"
Expand All @@ -441,8 +435,10 @@ gateway-client = { path = "clients/gateway-client" }
# is "fine", because SP/MGS communication maintains forwards and backwards
# compatibility, but will mean that faux-mgs might be missing new
# functionality.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less important on this commit than the upcoming one, but we should probably do what this comment says and update package-manifest.toml too.

gateway-messages = { git = "https://github.com/oxidecomputer/management-gateway-service", rev = "f9566e68e0a0ccb7c3eeea081ae1cea279c11b2a", default-features = false, features = ["std"] }
gateway-sp-comms = { git = "https://github.com/oxidecomputer/management-gateway-service", rev = "f9566e68e0a0ccb7c3eeea081ae1cea279c11b2a" }
#
gateway-ereport-messages = { git = "https://github.com/oxidecomputer/management-gateway-service", rev = "57536869418e08667824c9a1b2cf115ed91b713f", default-features = false, features = ["debug-impls"] }
gateway-messages = { git = "https://github.com/oxidecomputer/management-gateway-service", rev = "57536869418e08667824c9a1b2cf115ed91b713f", default-features = false, features = ["std"] }
gateway-sp-comms = { git = "https://github.com/oxidecomputer/management-gateway-service", rev = "57536869418e08667824c9a1b2cf115ed91b713f" }
gateway-test-utils = { path = "gateway-test-utils" }
gateway-types = { path = "gateway-types" }
gethostname = "0.5.0"
Expand Down Expand Up @@ -647,6 +643,7 @@ scopeguard = "1.2.0"
secrecy = "0.10.0"
semver = { version = "1.0.25", features = ["std", "serde"] }
serde = { version = "1.0", default-features = false, features = [ "derive", "rc" ] }
serde_cbor = "0.11.2"
serde_human_bytes = { git = "https://github.com/oxidecomputer/serde_human_bytes", branch = "main" }
serde_json = "1.0.139"
serde_tokenstream = "0.2"
Expand Down Expand Up @@ -743,6 +740,7 @@ wicket-common = { path = "wicket-common" }
wicketd-api = { path = "wicketd-api" }
wicketd-client = { path = "clients/wicketd-client" }
xshell = "0.2.7"
zerocopy = "0.8.25"
zeroize = { version = "1.8.1", features = ["zeroize_derive", "std"] }
zip = { version = "2.6.0", default-features = false, features = ["deflate","bzip2"] }
zone = { version = "0.3.1", default-features = false, features = ["async"] }
Expand Down
Loading
Loading