Handle nullable array items. #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Openapi represents an array of nullable items using an allOf with exactly one reference entry (items.allOf[0].$ref), rather than the usual items.$ref. We currently treat these types as any, which means users have to cast or marshal and unmarshal data to the correct type. This patch adds a check for this edge case and replaces the any with the appropriate concrete type. Part of #340.
sudomateo
approved these changes
Nov 19, 2025
Collaborator
sudomateo
left a comment
sudomateo
left a comment
There was a problem hiding this comment.
This is clear to me and the Distributionint64 and Distributiondouble structs are already present in the SDK. Thanks for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openapi represents an array of nullable items using an allOf with exactly one reference entry (items.allOf[0].$ref), rather than the usual items.$ref. We currently treat these types as any, which means users have to cast or marshal and unmarshal data to the correct type. This patch adds a check for this edge case and replaces the any with the appropriate concrete type.
Part of #340.