Skip to content

Conversation

@ThierryBerger
Copy link
Contributor

@ThierryBerger ThierryBerger commented Nov 17, 2019

Related to #291

Impacts would only be "BombPush" ability used on ally Heavy agents.

Features:

  • Weight logic for BombPush
  • Same logic for FlyOff effect
  • Visualization for failed knockback
  • PR for assets/objects.ron definitions : added weight to objects zemeroth_assets#6
  • Tests for Knockback
  • Tests for FlyOff

@ThierryBerger
Copy link
Contributor Author

ThierryBerger commented Dec 14, 2019

Ok tests are not passing now, there must be something not deterministic in there, sometimes is succeeds and sometimes not, I guess the simplest fix is to split the test in 2 : "heavy" and "normal".

I separated tests for "heavy" and "normal", but ❗️ there's no test to actually make sure the movement was indeed applied for "normal", but not applied for "heavy"

@ozkriff
Copy link
Owner

ozkriff commented Jan 14, 2020

Could you rebase on top of the master branch (to fix Travis checks), please?

@ozkriff
Copy link
Owner

ozkriff commented Jan 14, 2020

Also, this PR should be paired with a PR to https://github.com/ozkriff/zemeroth_assets/blob/master/objects.ron otherwise the actual game crashes during initialization with a 'Can't parse the prototypes: Message("missing field `weight`")' msg.

@ozkriff ozkriff merged commit 2e3a0b8 into ozkriff:master Jan 22, 2020
@ozkriff
Copy link
Owner

ozkriff commented Jan 22, 2020

Added a few final touches.

Thanks for the PR again, @Vrixyz!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants