Update dependencies#1004
Conversation
WalkthroughThe changes bump the Go toolchain to 1.25.3 across modules, update Kubernetes client libraries to v0.35.0 and controller-runtime to v0.23.1 (with indirect dependency adjustments), enable KinD cluster retention on creation, and update CI to use Go 1.25.3. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
modules/kind/kindcluster.go (1)
149-156:⚠️ Potential issue | 🟠 MajorCreateWithRetain(true) skips failure cleanup; confirm caller cleanup patterns.
CreateWithRetain(true)prevents kind from deleting node containers on Create() failure, leaving them for debugging. The Create() method has no error recovery or cleanup on failure, so failed creates require explicit Destroy() calls from callers. Verify that:
- Callers properly handle cleanup after failed Create() (e.g., via deferred Destroy or try-finally patterns)
- This behavior is documented as part of the API contract
- CI/dev environments can safely handle container/network remnants from failed cluster creations
Alternatively, add error recovery in Create() to automatically call Destroy on failure, or use CreateWithRetain(false).
🤖 Fix all issues with AI agents
In `@go.mod`:
- Line 3: The go.mod change sets the module toolchain to "go 1.25.3", so ensure
all build environments are updated before merging: update CI configs and runner
images (e.g., GitHub Actions workflows, Dockerfile build images, any
alpine/golang base images) to install Go 1.25.3 or newer, adjust any pinned
toolchain settings in build scripts, and update developer docs/local setup
instructions to reflect "go 1.25.3"; verify by running the CI build locally or
in a staging pipeline to confirm compatibility with the new go directive.
| module pkg.package-operator.run/cardboard | ||
|
|
||
| go 1.24.6 | ||
| go 1.25.3 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Go 1.25.3 release date and toolchain requirements
💡 Result:
- Go 1.25.3 release date: October 13, 2025. [1]
- Toolchain requirements (building from source): Go 1.25.x requires a Go 1.22 bootstrap toolchain (or newer) available on
PATHor viaGOROOT_BOOTSTRAP, plus the usual system C toolchain for your platform. [2] - Language/toolchain versioning note: Go 1.25.3 is a patch release in the Go 1.25 family (language version 1.25). [3]
Sources: [1] Go release history, [2] “Installing Go from source”, [3] “Go Toolchains” documentation.
Ensure CI/build pipelines support Go 1.25.3 before merging.
The go 1.25.3 directive requires all build environments to have access to this toolchain version. Verify that Docker images, CI runners, and local dev setup guidance are updated to include Go 1.25.3 (or newer) before this change lands, since builds will fail on systems with only Go 1.24 or earlier available.
🤖 Prompt for AI Agents
In `@go.mod` at line 3, The go.mod change sets the module toolchain to "go
1.25.3", so ensure all build environments are updated before merging: update CI
configs and runner images (e.g., GitHub Actions workflows, Dockerfile build
images, any alpine/golang base images) to install Go 1.25.3 or newer, adjust any
pinned toolchain settings in build scripts, and update developer docs/local
setup instructions to reflect "go 1.25.3"; verify by running the CI build
locally or in a staging pipeline to confirm compatibility with the new go
directive.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
=======================================
Coverage 63.33% 63.33%
=======================================
Files 13 13
Lines 870 870
=======================================
Hits 551 551
Misses 280 280
Partials 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.