Skip to content

Update dependencies#1004

Merged
thetechnick merged 3 commits intopackage-operator:mainfrom
thetechnick:update-dependencies
Feb 5, 2026
Merged

Update dependencies#1004
thetechnick merged 3 commits intopackage-operator:mainfrom
thetechnick:update-dependencies

Conversation

@thetechnick
Copy link
Contributor

No description provided.

@thetechnick thetechnick requested a review from a team as a code owner February 5, 2026 14:53
@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Walkthrough

The changes bump the Go toolchain to 1.25.3 across modules, update Kubernetes client libraries to v0.35.0 and controller-runtime to v0.23.1 (with indirect dependency adjustments), enable KinD cluster retention on creation, and update CI to use Go 1.25.3.

Changes

Cohort / File(s) Summary
Root & OCI Go version
go.mod, modules/oci/go.mod
Bumped Go toolchain from 1.24.6 to 1.25.3; no other functional dependency changes.
kubeutils module
kubeutils/go.mod
Upgraded Kubernetes requires to v0.35.0, bumped sigs.k8s.io/controller-runtime to v0.23.1, and adjusted multiple indirect deps (kube-openapi, utils, structured-merge-diff, etc.).
kubeclients module
modules/kubeclients/go.mod
Bumped Go to 1.25.3, upgraded k8s.io/* deps to v0.35.0, controller-runtime to v0.23.1, reconciled requires/replaces and updated indirects.
kind module (go.mod + code)
modules/kind/go.mod, modules/kind/kindcluster.go
go.mod: bumped to Go 1.25.3 and added local replace directives. kindcluster.go: changed cluster.CreateWithRetain from false to true (retain cluster after creation).
CI workflow & tooling
.github/workflows/testing.yaml, cmd/build/main.go
CI workflow steps updated to use Go 1.25.3; cmd/build/main.go updated golangci-lint version from 2.3.1 to 2.8.0.
Minor lint comment
kubeutils/kubemanifests/load.go
Removed nolint:prealloc comment before objects slice declaration; no functional change.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update dependencies' is directly related to the changeset, which comprehensively updates Go toolchain versions, Kubernetes dependencies, and related packages across multiple modules.
Description check ✅ Passed No description was provided by the author; this is a lenient check that passes as long as the title adequately conveys the changeset purpose, which it does.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
modules/kind/kindcluster.go (1)

149-156: ⚠️ Potential issue | 🟠 Major

CreateWithRetain(true) skips failure cleanup; confirm caller cleanup patterns.

CreateWithRetain(true) prevents kind from deleting node containers on Create() failure, leaving them for debugging. The Create() method has no error recovery or cleanup on failure, so failed creates require explicit Destroy() calls from callers. Verify that:

  1. Callers properly handle cleanup after failed Create() (e.g., via deferred Destroy or try-finally patterns)
  2. This behavior is documented as part of the API contract
  3. CI/dev environments can safely handle container/network remnants from failed cluster creations

Alternatively, add error recovery in Create() to automatically call Destroy on failure, or use CreateWithRetain(false).

🤖 Fix all issues with AI agents
In `@go.mod`:
- Line 3: The go.mod change sets the module toolchain to "go 1.25.3", so ensure
all build environments are updated before merging: update CI configs and runner
images (e.g., GitHub Actions workflows, Dockerfile build images, any
alpine/golang base images) to install Go 1.25.3 or newer, adjust any pinned
toolchain settings in build scripts, and update developer docs/local setup
instructions to reflect "go 1.25.3"; verify by running the CI build locally or
in a staging pipeline to confirm compatibility with the new go directive.

module pkg.package-operator.run/cardboard

go 1.24.6
go 1.25.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Go 1.25.3 release date and toolchain requirements

💡 Result:

  • Go 1.25.3 release date: October 13, 2025. [1]
  • Toolchain requirements (building from source): Go 1.25.x requires a Go 1.22 bootstrap toolchain (or newer) available on PATH or via GOROOT_BOOTSTRAP, plus the usual system C toolchain for your platform. [2]
  • Language/toolchain versioning note: Go 1.25.3 is a patch release in the Go 1.25 family (language version 1.25). [3]

Sources: [1] Go release history, [2] “Installing Go from source”, [3] “Go Toolchains” documentation.


Ensure CI/build pipelines support Go 1.25.3 before merging.

The go 1.25.3 directive requires all build environments to have access to this toolchain version. Verify that Docker images, CI runners, and local dev setup guidance are updated to include Go 1.25.3 (or newer) before this change lands, since builds will fail on systems with only Go 1.24 or earlier available.

🤖 Prompt for AI Agents
In `@go.mod` at line 3, The go.mod change sets the module toolchain to "go
1.25.3", so ensure all build environments are updated before merging: update CI
configs and runner images (e.g., GitHub Actions workflows, Dockerfile build
images, any alpine/golang base images) to install Go 1.25.3 or newer, adjust any
pinned toolchain settings in build scripts, and update developer docs/local
setup instructions to reflect "go 1.25.3"; verify by running the CI build
locally or in a staging pipeline to confirm compatibility with the new go
directive.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.33%. Comparing base (767e48a) to head (07750b4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/build/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1004   +/-   ##
=======================================
  Coverage   63.33%   63.33%           
=======================================
  Files          13       13           
  Lines         870      870           
=======================================
  Hits          551      551           
  Misses        280      280           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thetechnick thetechnick enabled auto-merge (squash) February 5, 2026 15:08
@thetechnick thetechnick disabled auto-merge February 5, 2026 15:08
@thetechnick thetechnick merged commit 204ea02 into package-operator:main Feb 5, 2026
4 of 5 checks passed
@thetechnick thetechnick deleted the update-dependencies branch February 5, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant