-
Notifications
You must be signed in to change notification settings - Fork 191
Namespace: explicit parsing errors #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR requires the parser to throw an error if a (percent-encoded) solidus `/` is encountered in any path segment. Signed-off-by: Piotr P. Karwasz <[email protected]>
Originally posted by @matt-phylum in #452 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ppkarwasz I'm not sure if you overlooked replacing "solidus" with "slash" or instead are insistent on using "solidus". I have no linguistic objection to that beautiful Latin-based word, but we don't use it anywhere else in the spec -- it's slashes all the way down -- and RFC 3986 similarly uses "slash" not "solidus". Some famous person somewhere once said something like "a foolish consistency is the hobgoblin of small minds", but imho consistency in the terms we use is a distinct advantage.
What do you think?
I didn't notice it. Fixed in 9bd2568 Regarding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ppkarwasz -- LGTM!
This PR contains the part of #452 that is specific to
namespace
.It requires the parser to throw an error if a (percent-encoded) solidus
/
is encountered in any path segment.