Stop building wheel from Git checkout in CI/CD#260
Open
jpopelka wants to merge 1 commit intopackit:mainfrom
Open
Stop building wheel from Git checkout in CI/CD#260jpopelka wants to merge 1 commit intopackit:mainfrom
jpopelka wants to merge 1 commit intopackit:mainfrom
Conversation
When python -m build is invoked with --sdist and/or --wheel args, both artifacts get created from source. This is bad because it differs from what pip does when it needs to build a package from the source distribution before installation.
Contributor
|
Build failed. ✔️ pre-commit SUCCESS in 1m 47s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When python -m build is invoked with --sdist and/or --wheel args, both artifacts get created from source. This is bad because it differs from what pip does when it needs to build a package from the source distribution before installation.
See also: packit/packit#1734, packit/ogr#778