Automatic Docker builds #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnavetta
commented
Mar 6, 2021
| --mount=type=cache,target=/app/target \ | ||
| cargo install --path . | ||
|
|
||
| FROM debian:buster-slim |
Collaborator
Author
There was a problem hiding this comment.
Should be a bit smaller than the ubuntu base image
| COPY . /app | ||
| WORKDIR /app | ||
|
|
||
| RUN --mount=type=cache,target=/usr/local/cargo/registry \ |
Collaborator
Author
There was a problem hiding this comment.
Because of how Docker's caching implementation works, we have to copy any build results out of the directory that's mounted as a cache
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
| registry: docker.pkg.github.com | ||
| repository: theadd336/THavalonWeb/thavalon-server |
Collaborator
Author
There was a problem hiding this comment.
🤞 this should work. I'm not entirely sure how the GitHub Packages setup works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses GitHub actions to automatically build Docker images. It uses new caching features so that builds don't have to re-fetch all our dependencies each time. It also automatically pushes to GitHub's Docker image registry, so we can download and run images from there.
The build will run on every commit to master, and can also be triggered manually from GitHub.
Testing
I built and started the images locally, with a few small changes, to make sure the caching worked. I'm not sure how to test the GitHub Actions part until it's merged, however.