added fluent WithIdentityInsert() method in order to deactivate and reactivate Identity insert in an sql database. Added a test project using TestContainers #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancisGauthier
changed the title
…eactivate Identity insert in an sql database. added a test project with a test container to run an actual sql server for testing purposes
Signed-off-by: Francis Gauthier <[email protected]>
Signed-off-by: Francis Gauthier <[email protected]>
Signed-off-by: Francis Gauthier <[email protected]>
|
Hi, its been a while the pr is open. I rebased the code and reverted some code i accidentally pushed in my fork. Let me know if i can help with anything else. I think this would be a nice addition to this library. We do use that library for a custom ETL in a project and keeping the identity ids is really helpfull. Otherwise we have to disable and reenable identity columns before and after ETL processes Thanks, |
|
Hi @FrancisGauthier thanks for the PR. I will check your PR closely. As this part of the code you changed is very sensitive, I wanted to give me more time to check... but I don't have much of it lol. Can you describe me in more details the problem you want to address with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added fluent WithIdentityInsert() with EFSave method in order to deactivate and reactivate Identity insert in an sql database.
added a test project with a test container to run an actual sql server for testing purposes.
Requires docker installed
Need to add test executions in the pipeline/workflow. This can be added in another PR or within this one.