Skip to content

Conversation

@O957
Copy link

@O957 O957 commented Jun 18, 2025

This PR:

  • Adds an air.toml file (configuration file for air).
  • Adds changes made from running air format .
  • Adds format-check.yaml, a GitHub action workflow that checks if air formatting changes need to be made (i.e. if the user has not yet ran air format .)

Why?

  • Code across codebase adheres to same formatting standards.
  • Code looks cleaner.

Context:

The formats made in this PR are guided by the configuration specified in air.toml (also in the PR). The workflow for developers of rphylopic would be to (1) install air, (2) run air format . or air format . --check before committing, and (3) run air format . later if format-check.yaml finds R scripts that do not adhere to the format specifications.

Air Configuration File

[format]
line-width = 80
indent-width = 2
indent-style = "space"
line-ending = "auto"
persistent-line-breaks = true
exclude = []
default-exclude = true
skip = []

@O957
Copy link
Author

O957 commented Jun 18, 2025

I can add air to other paleoverse repositories as well if the developers here believe it would be helpful. I use the paleoverse tools semi-often and, out of respect, want them to be as clean / standardized as is nice / helpful.

@willgearty
Copy link
Member

Thanks for submitting this PR! We're both pretty busy at the moment, but I'll get around to reviewing this when I get some free time.

@O957
Copy link
Author

O957 commented Jun 25, 2025

I can add air to other paleoverse repositories as well if the developers here believe it would be helpful. I use the paleoverse tools semi-often and, out of respect, want them to be as clean / standardized as is nice / helpful.

This remark still applies to paleoverse repositories, but I am making a note here that I am about to make the same PR in https://github.com/ropensci/paleobioDB, which I use even more frequently than any given paleoverse repository. I saw you @willgearty were a contributor and got concerned that the aforementioned repository isn't sufficiently independent to warrent going ahead with the PR. Looking at the contributions though https://github.com/ropensci/paleobioDB/graphs/contributors I can see that the lead developers are sufficiently varied / different to justify the PRs existing in parallel instead of sequentially. Hope everything is going well and again no rush; thank you for the willingness to engage with this PR. Another thing worth mentioning is that I found no CODEOWNERS files in this repository or in paleobioDB. I can make an issue with more information / justifications (and a PR later on) if you are interested.

@willgearty willgearty added this to the 1.7.0 milestone Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants