[Checkbox] refactor indicators style #2721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 24, 2018 14:05
Adjust font-size in large, everything recomputes! Refactor all controls to leverage this (Switch needs a little more work)
one property replaces six!
Bring Switch large & dark variants inside its block
move large modifier up to general sectionPreview: documentation | landing | table |
lintPreview: documentation | landing | table |
|
|
||
| input:checked:disabled ~ .#{$ns}-control-indicator::before { | ||
| box-shadow: none; | ||
| background-image: radial-gradient(rgba($white, 0.5) 0%, rgba($white, 0.5) 28%, transparent 32%); |
Contributor
There was a problem hiding this comment.
maybe just opacity: 50%?
themadcreator
approved these changes
Jul 24, 2018
opacity for disabled radioPreview: documentation | landing | table |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1emfor size so all we have to do for large is bump thefont-sizeindicator-colors()mixin for legibility & remove unused variables